mbox series

[4.4.y-cip,v2,00/15] PM / OPP v2 & cpufreq backports part 1

Message ID 20200608093028.21612-1-wens@csie.org (mailing list archive)
Headers show
Series PM / OPP v2 & cpufreq backports part 1 | expand

Message

Chen-Yu Tsai June 8, 2020, 9:30 a.m. UTC 
(resending from correct address...)

Hi everyone,

This is v2 of the part 1 of MOXA's PM / OPP / cpufreq backport series.
Changes since v1:

  - Added missing SoB and upstream commit hash for "PM / OPP: Set
    cpu_dev->id in cpumask first"

Original cover letter:

This is part 1 of MOXA's PM / OPP / cpufreq backport series. The whole
series aims to backport patches related to PM / OPPv2 and cpufreq
which were included in the v4.4 kernel from TI's SDK. The end goal is
to include cpufreq-ti and convert am33xx to using it and OPPv2.

Part 1 here includes patches from the v4.5 cycle, listed in topological
order:

    deaa51465105 PM / OPP: Add debugfs support
    1c4d12de2719 PM / OPP: Add "opp-supported-hw" binding
    ffdb8cc7a27c PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding
    af87a39a5f7c PM / OPP: Remove 'operating-points-names' binding
    754dcf35f346 PM / OPP: Rename OPP nodes as opp@<opp-hz>
    dc4e7b1fa20a PM / OPP: Add missing doc comments
    7de36b0aa51a PM / OPP: Parse 'opp-supported-hw' binding
    01fb4d3c39d3 PM / OPP: Parse 'opp-<prop>-<name>' bindings
    fd8d8e63467c PM / OPP: Fix parsing of opp-microvolt and opp-microamp properties
    d9de19b1cc01 PM / OPP: Set cpu_dev->id in cpumask first
    5ff24d601092 PM / OPP: Use snprintf() instead of sprintf()
    3be3f8f36e73 devicetree: bindings: Add optional dynamic-power-coefficient property
    f8fa8ae06b8c cpufreq-dt: Supply power coefficient when registering cooling devices
    929ca89c305a cpufreq-dt: fix handling regulator_get_voltage() result
    b331bc20d928 cpufreq: cpufreq-dt: avoid uninitialized variable warnings:

Of these,

    dc4e7b1fa20a PM / OPP: Add missing doc comments

was identified as a patch dependency, but otherwise serves no purpose. And

    d9de19b1cc01 PM / OPP: Set cpu_dev->id in cpumask first

was found while looking through git logs. Last,

    3be3f8f36e73 devicetree: bindings: Add optional dynamic-power-coefficient property

is related to

    f8fa8ae06b8c cpufreq-dt: Supply power coefficient when registering cooling devices

All other patches were included from TI's SDK.

The patches apply cleanly on top of linux-4.4.y-cip. Please have a look.


Regards
ChenYu


Andrzej Hajda (1):
  cpufreq-dt: fix handling regulator_get_voltage() result

Arnd Bergmann (1):
  cpufreq: cpufreq-dt: avoid uninitialized variable warnings:

Bartlomiej Zolnierkiewicz (1):
  PM / OPP: Fix parsing of opp-microvolt and opp-microamp properties

Pi-Cheng Chen (1):
  PM / OPP: Set cpu_dev->id in cpumask first

Punit Agrawal (2):
  devicetree: bindings: Add optional dynamic-power-coefficient property
  cpufreq-dt: Supply power coefficient when registering cooling devices

Viresh Kumar (9):
  PM / OPP: Add debugfs support
  PM / OPP: Add "opp-supported-hw" binding
  PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding
  PM / OPP: Remove 'operating-points-names' binding
  PM / OPP: Rename OPP nodes as opp@<opp-hz>
  PM / OPP: Add missing doc comments
  PM / OPP: Parse 'opp-supported-hw' binding
  PM / OPP: Parse 'opp-<prop>-<name>' bindings
  PM / OPP: Use snprintf() instead of sprintf()

 .../devicetree/bindings/arm/cpus.txt          |  17 +
 Documentation/devicetree/bindings/opp/opp.txt | 132 +++++--
 drivers/base/power/opp/Makefile               |   1 +
 drivers/base/power/opp/core.c                 | 336 +++++++++++++++++-
 drivers/base/power/opp/cpu.c                  |   3 +-
 drivers/base/power/opp/debugfs.c              | 219 ++++++++++++
 drivers/base/power/opp/opp.h                  |  53 ++-
 drivers/cpufreq/cpufreq-dt.c                  |  29 +-
 include/linux/pm_opp.h                        |  22 ++
 9 files changed, 742 insertions(+), 70 deletions(-)
 create mode 100644 drivers/base/power/opp/debugfs.c

Comments

Pavel Machek June 8, 2020, 9:37 p.m. UTC | #1 
Hi!

> This is v2 of the part 1 of MOXA's PM / OPP / cpufreq backport series.
> Changes since v1:
> 
>   - Added missing SoB and upstream commit hash for "PM / OPP: Set
>     cpu_dev->id in cpumask first"

...

>     01fb4d3c39d3 PM / OPP: Parse 'opp-<prop>-<name>' bindings
>     fd8d8e63467c PM / OPP: Fix parsing of opp-microvolt and

OPP subsystem is shared with other boards, so I believe we should be
careful here. 01fb4d3c39d3 introduces a bug and fd8d8e63467c fixes
it. I believe it would be better to merge them together. Adding a note
such as:

[Merged Bartlomiej Zolnierkiewicz's <b.zolnierkie@samsung.com>
upstream commit fd8d8e63467c922be9ae4452cca2980d473477d9 to fix a bug]

before your signoff should do the trick.

Best regards,
								Pavel