diff mbox series

[6.1.y-cip,13/20] arm64: dts: renesas: rzg2lc-smarc: Link DSI with ADV7535

Message ID 20230905160737.167877-14-biju.das.jz@bp.renesas.com (mailing list archive)
State Accepted
Headers show
Series Add Renesas RZ/G2L DSI,VSP,FCP support | expand

Commit Message

Biju Das Sept. 5, 2023, 4:07 p.m. UTC 
commit 961eed28296853a81d792654f392773800df91db upstream.

Enable DSI and ADV7535 and link DSI with ADV7535 on RZ/G2LC SMARC EVK.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230411100346.299768-9-biju.das.jz@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 79 +++++++++++++++++++
 1 file changed, 79 insertions(+)

Comments

Pavel Machek Sept. 6, 2023, 8:18 a.m. UTC | #1 
Hi!

> commit 961eed28296853a81d792654f392773800df91db upstream.
> 
> Enable DSI and ADV7535 and link DSI with ADV7535 on RZ/G2LC SMARC EVK.

There seems to be a bit of duplication between different dts
fragments. Would it make sense to put common parts into dtsi
somewhere?

Best regards,
								Pavel
Biju Das Sept. 6, 2023, 8:23 a.m. UTC | #2 
Hi Pavel Machek,

> Subject: Re: [PATCH 6.1.y-cip 13/20] arm64: dts: renesas: rzg2lc-smarc:
> Link DSI with ADV7535
> 
> Hi!
> 
> > commit 961eed28296853a81d792654f392773800df91db upstream.
> >
> > Enable DSI and ADV7535 and link DSI with ADV7535 on RZ/G2LC SMARC EVK.
> 
> There seems to be a bit of duplication between different dts fragments.
> Would it make sense to put common parts into dtsi somewhere?

I cannot put to common file for RZ/{G2L,G2LC,G2UL,V2L} as
RZ/G2UL uses DPI compared to DSI.

Currently RZ/G2L and RZ/V2L share the common dtb as it has both DSI/DPI interface.

RZ/G2LC has only DSI interface.
RZ/G2UL has only DPI interface.

Cheers,
Biju
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
index b6bd27196d88..6818fd49b2be 100644
--- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
@@ -17,6 +17,23 @@  aliases {
 		serial1 = &scif1;
 		i2c2 = &i2c2;
 	};
+
+	osc1: cec-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <12000000>;
+	};
+
+	hdmi-out {
+		compatible = "hdmi-connector";
+		type = "d";
+
+		port {
+			hdmi_con_out: endpoint {
+				remote-endpoint = <&adv7535_out>;
+			};
+		};
+	};
 };
 
 #if (SW_SCIF_CAN || SW_RSPI_CAN)
@@ -36,6 +53,68 @@  &cpu_dai {
 	sound-dai = <&ssi0>;
 };
 
+&dsi {
+	status = "okay";
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			dsi0_in: endpoint {
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+			dsi0_out: endpoint {
+				data-lanes = <1 2 3 4>;
+				remote-endpoint = <&adv7535_in>;
+			};
+		};
+	};
+};
+
+&i2c1 {
+	adv7535: hdmi@3d {
+		compatible = "adi,adv7535";
+		reg = <0x3d>;
+
+		interrupt-parent = <&pinctrl>;
+		interrupts = <RZG2L_GPIO(43, 1) IRQ_TYPE_EDGE_FALLING>;
+		clocks = <&osc1>;
+		clock-names = "cec";
+		avdd-supply = <&reg_1p8v>;
+		dvdd-supply = <&reg_1p8v>;
+		pvdd-supply = <&reg_1p8v>;
+		a2vdd-supply = <&reg_1p8v>;
+		v3p3-supply = <&reg_3p3v>;
+		v1p2-supply = <&reg_1p8v>;
+
+		adi,dsi-lanes = <4>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				adv7535_in: endpoint {
+					remote-endpoint = <&dsi0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				adv7535_out: endpoint {
+					remote-endpoint = <&hdmi_con_out>;
+				};
+			};
+		};
+	};
+};
+
 &i2c2 {
 	pinctrl-0 = <&i2c2_pins>;
 	pinctrl-names = "default";