mbox series

[0/3] XOR Math Fixups: translation & position

Message ID cover.1714159486.git.alison.schofield@intel.com
Headers show
Series XOR Math Fixups: translation & position | expand

Message

Alison Schofield April 26, 2024, 7:51 p.m. UTC
From: Alison Schofield <alison.schofield@intel.com>

Rather than repeat the individual patch commit message content,
let me describe the flow of this set:

Patch 1: cxl/acpi: Restore XOR'd position bits during address translation
The problem fixed in this patch, bad HPA translations with XOR math,
came to my attention recently. Patch 1 can stand alone, but since that
discovery also shed light on how to repair an issue with calculating
positions in interleave sets (Patch 2,3) they are presented together.

Patch 2 & Patch 3 are paired. Patch 2 presents the new method for
verifying a target position in the list and Patch 3 removes the
old method. These 2 could be squashed.

FYI - the reason I don't present the code removal first is because
I think it is easier to read the diff if I leave in the old root
decoder call back setup for calc_hb, insert the new call back along
the same path, and then rip out the defunct calc_hb. That's the
way I created the patchset and it may be an easier way for reviewers
to follow along with the root decoder callback setup.


Alison Schofield (3):
  cxl/acpi: Restore XOR'd position bits during address translation
  cxl/region: Verify target positions using the ordered target list
  cxl: Remove defunct code calculating host bridge target positions

 drivers/cxl/acpi.c        | 76 ++++++++++++++++-----------------------
 drivers/cxl/core/port.c   | 21 ++---------
 drivers/cxl/core/region.c |  9 ++++-
 drivers/cxl/core/trace.c  |  5 +++
 drivers/cxl/cxl.h         | 10 +++---
 5 files changed, 51 insertions(+), 70 deletions(-)


base-commit: 4cece764965020c22cff7665b18a012006359095