Message ID | 1537571127-10143-14-git-send-email-bmarzins@redhat.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Delegated to: | christophe varoqui |
Headers | show |
Series | Misc Multipath patches | expand |
On Fri, 2018-09-21 at 18:05 -0500, Benjamin Marzinski wrote: > The code is attempting to verify that 0 <= k < 3 > However, sizeof(val) is 12, assuming 4 byte integers. The check needs > to > take integer size into account. Found by coverity. > > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> Reviewed-by: Martin Wilck <mwilck@suse.com> > --- > multipath/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/multipath/main.c b/multipath/main.c > index fc5bf16..d5aad95 100644 > --- a/multipath/main.c > +++ b/multipath/main.c > @@ -482,7 +482,7 @@ static int print_cmd_valid(int k, const vector > pathvec, > struct timespec until; > struct path *pp; > > - if (k < 0 || k >= sizeof(vals)) > + if (k < 0 || k >= (sizeof(vals) / sizeof(int))) > return 1; > > if (k == 2) {
diff --git a/multipath/main.c b/multipath/main.c index fc5bf16..d5aad95 100644 --- a/multipath/main.c +++ b/multipath/main.c @@ -482,7 +482,7 @@ static int print_cmd_valid(int k, const vector pathvec, struct timespec until; struct path *pp; - if (k < 0 || k >= sizeof(vals)) + if (k < 0 || k >= (sizeof(vals) / sizeof(int))) return 1; if (k == 2) {
The code is attempting to verify that 0 <= k < 3 However, sizeof(val) is 12, assuming 4 byte integers. The check needs to take integer size into account. Found by coverity. Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> --- multipath/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)