diff mbox series

[v3,16/19] multipathd: remove useless check and fix format

Message ID 1537571127-10143-17-git-send-email-bmarzins@redhat.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series Misc Multipath patches | expand

Commit Message

Benjamin Marzinski Sept. 21, 2018, 11:05 p.m. UTC
The only thing this patch changes is to remove the check for pp->mpp
before the check for pp->mpp->prflags, since check_path() already
verified that pp->mpp != NULL. This fixes a number of coverity warnings.
Also, I normalized the spacing and indenting of the nearby code.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 multipathd/main.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Martin Wilck Oct. 1, 2018, 9:40 p.m. UTC | #1
On Fri, 2018-09-21 at 18:05 -0500, Benjamin Marzinski wrote:
> The only thing this patch changes is to remove the check for pp->mpp
> before the check for pp->mpp->prflags, since check_path() already
> verified that pp->mpp != NULL. This fixes a number of coverity
> warnings.
> Also, I normalized the spacing and indenting of the nearby code.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

Reviewed-by: Martin Wilck <mwilck@suse.com>

> ---
>  multipathd/main.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 125a805..3c2fe7b 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -1978,14 +1978,14 @@ check_path (struct vectors * vecs, struct
> path * pp, int ticks)
>  			return 1;
>  		}
>  
> -		if(newstate == PATH_UP || newstate == PATH_GHOST){
> -			if ( pp->mpp && pp->mpp->prflag ){
> +		if (newstate == PATH_UP || newstate == PATH_GHOST) {
> +			if (pp->mpp->prflag) {
>  				/*
>  				 * Check Persistent Reservation.
>  				 */
> -			condlog(2, "%s: checking persistent reservation
> "
> -				"registration", pp->dev);
> -			mpath_pr_event_handle(pp);
> +				condlog(2, "%s: checking persistent "
> +					"reservation registration", pp-
> >dev);
> +				mpath_pr_event_handle(pp);
>  			}
>  		}
>
diff mbox series

Patch

diff --git a/multipathd/main.c b/multipathd/main.c
index 125a805..3c2fe7b 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -1978,14 +1978,14 @@  check_path (struct vectors * vecs, struct path * pp, int ticks)
 			return 1;
 		}
 
-		if(newstate == PATH_UP || newstate == PATH_GHOST){
-			if ( pp->mpp && pp->mpp->prflag ){
+		if (newstate == PATH_UP || newstate == PATH_GHOST) {
+			if (pp->mpp->prflag) {
 				/*
 				 * Check Persistent Reservation.
 				 */
-			condlog(2, "%s: checking persistent reservation "
-				"registration", pp->dev);
-			mpath_pr_event_handle(pp);
+				condlog(2, "%s: checking persistent "
+					"reservation registration", pp->dev);
+				mpath_pr_event_handle(pp);
 			}
 		}