mbox series

[00/12] drm/client: Use after free and debug improvements

Message ID 20240404203336.10454-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/client: Use after free and debug improvements | expand

Message

Ville Syrjälä April 4, 2024, 8:33 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Various improvements to the drm/client code:
- Fix a use after free (fairly routinely hit by i915 CI)
- Debug print improvements
- Cleanups/etc.

Ville Syrjälä (12):
  drm/client: Fully protect modes[] with dev->mode_config.mutex
  drm/client:
    s/drm_connector_has_preferred_mode/drm_connector_preferred_mode/
  drm/client: Use drm_mode_destroy()
  drm/client: Add a FIXME around crtc->mode usage
  drm/client: Nuke outdated fastboot comment
  drm/client: Constify modes
  drm/client: Use array notation for function arguments
  drm/client: Extract drm_connector_first_mode()
  drm/client: Switch to per-device debugs
  drm/client: Use [CONNECTOR:%d:%s] formatting
  drm/client: Streamline mode selection debugs
  drm/probe-helper: Switch to per-device debugs

 drivers/gpu/drm/drm_client_modeset.c | 237 ++++++++++++++-------------
 drivers/gpu/drm/drm_probe_helper.c   |  35 ++--
 2 files changed, 137 insertions(+), 135 deletions(-)

Comments

Thomas Zimmermann April 5, 2024, 8:04 a.m. UTC | #1 
Hi

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

for the whole series.

Best regards
Thomas

Am 04.04.24 um 22:33 schrieb Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Various improvements to the drm/client code:
> - Fix a use after free (fairly routinely hit by i915 CI)
> - Debug print improvements
> - Cleanups/etc.
>
> Ville Syrjälä (12):
>    drm/client: Fully protect modes[] with dev->mode_config.mutex
>    drm/client:
>      s/drm_connector_has_preferred_mode/drm_connector_preferred_mode/
>    drm/client: Use drm_mode_destroy()
>    drm/client: Add a FIXME around crtc->mode usage
>    drm/client: Nuke outdated fastboot comment
>    drm/client: Constify modes
>    drm/client: Use array notation for function arguments
>    drm/client: Extract drm_connector_first_mode()
>    drm/client: Switch to per-device debugs
>    drm/client: Use [CONNECTOR:%d:%s] formatting
>    drm/client: Streamline mode selection debugs
>    drm/probe-helper: Switch to per-device debugs
>
>   drivers/gpu/drm/drm_client_modeset.c | 237 ++++++++++++++-------------
>   drivers/gpu/drm/drm_probe_helper.c   |  35 ++--
>   2 files changed, 137 insertions(+), 135 deletions(-)
>