diff mbox

[-next,09/15] drm/vmwgfx: Remove primary memory validation against mode while creating fb

Message ID 20180703191500.2374-10-thellstrom@vmware.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thomas Hellstrom July 3, 2018, 7:14 p.m. UTC
From: Deepak Rawat <drawat@vmware.com>

This validation is not required because user-space will send create_fb
request once the memory is allocated. This check should be performed
during mode-setting.

Signed-off-by: Deepak Rawat <drawat@vmware.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 13 -------------
 1 file changed, 13 deletions(-)
diff mbox


diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 3605ac1702c2..f0ae0b2ee2e6 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -1433,19 +1433,6 @@  static struct drm_framebuffer *vmw_kms_fb_create(struct drm_device *dev,
 	struct ttm_base_object *user_obj;
 	int ret;
-	/**
-	 * This code should be conditioned on Screen Objects not being used.
-	 * If screen objects are used, we can allocate a GMR to hold the
-	 * requested framebuffer.
-	 */
-	if (!vmw_kms_validate_mode_vram(dev_priv,
-					mode_cmd->pitches[0],
-					mode_cmd->height)) {
-		DRM_ERROR("Requested mode exceed bounding box limit.\n");
-		return ERR_PTR(-ENOMEM);
-	}
 	 * Take a reference on the user object of the resource
 	 * backing the kms fb. This ensures that user-space handle