| Message ID | 20191021164654.9642-5-mihail.atanassov@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/komeda: Improve IRQ error event prints | expand |
On Mon, Oct 21, 2019 at 04:47:29PM +0000, Mihail Atanassov wrote: > Extra detail (normally off) almost never hurts. > > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com> > --- > drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++++++++++ > drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4 ++++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > index 4809000c1efb..d9fc9c48859a 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > @@ -51,6 +51,13 @@ > > #define KOMEDA_WARN_EVENTS KOMEDA_ERR_CSCE > > +#define KOMEDA_INFO_EVENTS ({0 \ > + | KOMEDA_EVENT_VSYNC \ > + | KOMEDA_EVENT_FLIP \ > + | KOMEDA_EVENT_EOW \ > + | KOMEDA_EVENT_MODE \ > + }) > + > /* malidp device id */ > enum { > MALI_D71 = 0, > @@ -211,6 +218,10 @@ struct komeda_dev { > u16 err_verbosity; > /* Print a single line per error per frame with error events. */ > #define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0) > + /* Print a single line per warning per frame with error events. */ > +#define KOMEDA_DEV_PRINT_WARN_EVENTS BIT(1) > + /* Print a single line per info event per frame with error events. */ > +#define KOMEDA_DEV_PRINT_INFO_EVENTS BIT(2) > /* Dump DRM state on an error or warning event. */ > #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) > }; > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c > index 5da61e7d75d5..bf88463bb4d9 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c > @@ -124,6 +124,10 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) > > if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) > print_evts |= KOMEDA_ERR_EVENTS; > + if (err_verbosity & KOMEDA_DEV_PRINT_WARN_EVENTS) > + print_evts |= KOMEDA_WARN_EVENTS; > + if (err_verbosity & KOMEDA_DEV_PRINT_INFO_EVENTS) > + print_evts |= KOMEDA_INFO_EVENTS; > > if (evts_mask & print_evts) { > char msg[256];
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index 4809000c1efb..d9fc9c48859a 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -51,6 +51,13 @@ #define KOMEDA_WARN_EVENTS KOMEDA_ERR_CSCE +#define KOMEDA_INFO_EVENTS ({0 \ + | KOMEDA_EVENT_VSYNC \ + | KOMEDA_EVENT_FLIP \ + | KOMEDA_EVENT_EOW \ + | KOMEDA_EVENT_MODE \ + }) + /* malidp device id */ enum { MALI_D71 = 0, @@ -211,6 +218,10 @@ struct komeda_dev { u16 err_verbosity; /* Print a single line per error per frame with error events. */ #define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0) + /* Print a single line per warning per frame with error events. */ +#define KOMEDA_DEV_PRINT_WARN_EVENTS BIT(1) + /* Print a single line per info event per frame with error events. */ +#define KOMEDA_DEV_PRINT_INFO_EVENTS BIT(2) /* Dump DRM state on an error or warning event. */ #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) }; diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index 5da61e7d75d5..bf88463bb4d9 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -124,6 +124,10 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) print_evts |= KOMEDA_ERR_EVENTS; + if (err_verbosity & KOMEDA_DEV_PRINT_WARN_EVENTS) + print_evts |= KOMEDA_WARN_EVENTS; + if (err_verbosity & KOMEDA_DEV_PRINT_INFO_EVENTS) + print_evts |= KOMEDA_INFO_EVENTS; if (evts_mask & print_evts) { char msg[256];
Extra detail (normally off) almost never hurts. Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++++++++++ drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4 ++++ 2 files changed, 15 insertions(+)