| Message ID | Y5Wwo6Gr1rJOdf3B@qemulion (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/fsl-dcu: Remove redundant error logging | expand |
On Sun, Dec 11, 2022 at 03:57:47PM +0530, Deepak R Varma wrote: Hello, May I please request a review and feedback on this patch proposal? Thank you, ./drv > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its return > value in the caller is redundant and should be removed. The clean up > also makes if condition block braces unnecessary. Remove that as well. > > Issue identified using platform_get_irq.cocci coccicheck script. > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > index 8579c7629f5e..1ba7d95e1956 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -272,10 +272,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) > } > > fsl_dev->irq = platform_get_irq(pdev, 0); > - if (fsl_dev->irq < 0) { > - dev_err(dev, "failed to get irq\n"); > + if (fsl_dev->irq < 0) > return fsl_dev->irq; > - } > > fsl_dev->regmap = devm_regmap_init_mmio(dev, base, > &fsl_dcu_regmap_config); > -- > 2.34.1 >
On 2022-12-11 11:27, Deepak R Varma wrote: > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its return > value in the caller is redundant and should be removed. The clean up > also makes if condition block braces unnecessary. Remove that as well. > > Issue identified using platform_get_irq.cocci coccicheck script. > > Signed-off-by: Deepak R Varma <drv@mailo.com> Reviewed-by: Stefan Agner <stefan@agner.ch> -- Stefan > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > index 8579c7629f5e..1ba7d95e1956 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -272,10 +272,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) > } > > fsl_dev->irq = platform_get_irq(pdev, 0); > - if (fsl_dev->irq < 0) { > - dev_err(dev, "failed to get irq\n"); > + if (fsl_dev->irq < 0) > return fsl_dev->irq; > - } > > fsl_dev->regmap = devm_regmap_init_mmio(dev, base, > &fsl_dcu_regmap_config); > -- > 2.34.1
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index 8579c7629f5e..1ba7d95e1956 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -272,10 +272,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) } fsl_dev->irq = platform_get_irq(pdev, 0); - if (fsl_dev->irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (fsl_dev->irq < 0) return fsl_dev->irq; - } fsl_dev->regmap = devm_regmap_init_mmio(dev, base, &fsl_dcu_regmap_config);
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well. Issue identified using platform_get_irq.cocci coccicheck script. Signed-off-by: Deepak R Varma <drv@mailo.com> --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.34.1