diff mbox series

[3/6] report: drop unused _xunit_make_section_report parameter

Message ID 20220620192934.21694-4-ddiss@suse.de (mailing list archive)
State New, archived
Headers show
Series check: minor cleanups and xunit report fix | expand

Commit Message

David Disseldorp June 20, 2022, 7:29 p.m. UTC 
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 common/report | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zorro Lang June 22, 2022, 4:37 a.m. UTC | #1 
On Mon, Jun 20, 2022 at 09:29:31PM +0200, David Disseldorp wrote:
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---
>  common/report | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/report b/common/report
> index 6cac71fc..bf05afa9 100644
> --- a/common/report
> +++ b/common/report
> @@ -152,7 +152,7 @@ _make_section_report()
>  	for report in $REPORT_LIST; do
>  		case "$report" in
>  		"xunit")
> -			_xunit_make_section_report "$test_status"
> +			_xunit_make_section_report

Hmm... I checked the history about _xunit_make_section_report, it was brought in
by f9fde7db2fa5 ("report: Add xunit format report generator") in 2017. But
it doesn't use any arguments at that time. So this "$test_status" is useless
from beginning.

Reviewed-by: Zorro Lang <zlang@redhat.com>


>  			;;
>  		*)
>  			_dump_err "format '$report' is not supported"
> -- 
> 2.35.3
>
diff mbox series

Patch

diff --git a/common/report b/common/report
index 6cac71fc..bf05afa9 100644
--- a/common/report
+++ b/common/report
@@ -152,7 +152,7 @@  _make_section_report()
 	for report in $REPORT_LIST; do
 		case "$report" in
 		"xunit")
-			_xunit_make_section_report "$test_status"
+			_xunit_make_section_report
 			;;
 		*)
 			_dump_err "format '$report' is not supported"