Message ID | 20190117130615.18732-1-pclouds@gmail.com (mailing list archive) |
---|---|
Headers | show
Return-Path: <git-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C4FC06C2 for <patchwork-git@patchwork.kernel.org>; Thu, 17 Jan 2019 13:06:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B3C4A2F754 for <patchwork-git@patchwork.kernel.org>; Thu, 17 Jan 2019 13:06:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B1A452F965; Thu, 17 Jan 2019 13:06:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 123EC2F914 for <patchwork-git@patchwork.kernel.org>; Thu, 17 Jan 2019 13:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726785AbfAQNGe (ORCPT <rfc822;patchwork-git@patchwork.kernel.org>); Thu, 17 Jan 2019 08:06:34 -0500 Received: from mail-pl1-f182.google.com ([209.85.214.182]:40376 "EHLO mail-pl1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfAQNGe (ORCPT <rfc822;git@vger.kernel.org>); Thu, 17 Jan 2019 08:06:34 -0500 Received: by mail-pl1-f182.google.com with SMTP id u18so4728744plq.7 for <git@vger.kernel.org>; Thu, 17 Jan 2019 05:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5SB6ipV/KOENimEW3NlYtoYvpMmAPzikgU4l8afb85g=; b=qsPzpwpnRqa9B5m0kAyNZHSStXY1CPWofDZrHeL51CpNuOpy5n9zAzbJqNRTDQ/eOK nj1tKBVd4cTPJ6qCY5gAqotEEotl2YWIP3jivxCL9RwEKJIShgLCxRR27BZnN/LituRB jQHvEE4Em4el5cQuwCVWQMJPX0dOuv/cZ1aZbr2Ht+pdcYDwmMjdceSlRCz8NO7K++5a ePsppZ++bR6qiZOZtDsZZkRrNwzniF9LbVvAYjRVUPM6GRWwK5Dg6/hXvo7ujcJGd4Li eltR4DDLzeut45k3W38tvPjW2vNyi8A/h2I9p9X5kDGOlLur7uGliwvCO0tmmA4dELQu J0Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5SB6ipV/KOENimEW3NlYtoYvpMmAPzikgU4l8afb85g=; b=qkesjBG0OUVIeggpcX96/GDKxBrSJw8oijTtjPE67UiSPkhrsRifIuZl71sjLOeTXL SIPq9U+TuhCa6fonMlMN5iVZgvBFMCQhWs9pa20917a8Lkxh2P+KWgDFUSzJkfxEpWEC e9l95p5ZN6yeeoiru61i92TBdu+Rc+DrFORdraZCIQDOx87CDhsSVyUHrjCBs/dkTyIF eJ862J2LVIZMFnweradrr+HUmXwe/fqAwjB7MuH27QWq6/45oQBfvLJLs2MoosAs2jlr ZDCI22YGP0cO8ArgM/PtFkV6KRRIG0PMpAc8dR3Os/fiwMtmMjhg4Rbcgqna69wNzDyu DXEA== X-Gm-Message-State: AJcUukfvxJO7OgDBMf7YayrCOO+U3dz8Yf+YMa92gOivNalKz+kOjd0g Rl6U6zzWYPmO419QZQNUKRtZGuXK X-Google-Smtp-Source: ALg8bN424/1ikSp/YQQSkjSu9wEWh1niM/IYpL8jaPPP3W83gFn2n8HKXqkMRrm5Uh3UmCqJ3tXw0Q== X-Received: by 2002:a17:902:1105:: with SMTP id d5mr14460054pla.47.1547730392910; Thu, 17 Jan 2019 05:06:32 -0800 (PST) Received: from ash ([115.72.21.220]) by smtp.gmail.com with ESMTPSA id i193sm7513278pgc.22.2019.01.17.05.06.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 05:06:32 -0800 (PST) Received: by ash (sSMTP sendmail emulation); Thu, 17 Jan 2019 20:06:27 +0700 From: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> To: git@vger.kernel.org Cc: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> Subject: [PATCH 00/76] Convert diff opt parser to parse_options() Date: Thu, 17 Jan 2019 20:04:59 +0700 Message-Id: <20190117130615.18732-1-pclouds@gmail.com> X-Mailer: git-send-email 2.20.0.482.g66447595a7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: <git.vger.kernel.org> X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
Convert diff opt parser to parse_options()
|
expand
|
On Thu, Jan 17 2019, Nguyễn Thái Ngọc Duy wrote: > This series converts diff option parsing to using parse-options. There > are a couple benefits of using parse-options, including "git <cmd> -h" > output, completion and less duplicate work. > > This is the first half. The second one would be converting the option > parser in revision.c. After that, the end game is, any command can > take a 'struct option[]' somewhere from diff/rev code, remove the > options they are not interested, then merge with their own options and > do parse_options() just once. There will be no separate parse phase > for revision/diff anymore. > > I sent a sneak peek [1] last year and got two good comments. I take it > people at least did not oppose to this. The most interesting parts are > at the top and bottom. The middle is just boring conversion, usually > one option per patch. I'm very much for this, and have skimmed it (but not stress tested) and it looks good to me. I have some WIP patches to --abbrev that conflict, but which will be simpler as a result of this.
On Thu, Jan 17, 2019 at 6:33 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote: > > I sent a sneak peek [1] last year and got two good comments. I take it > > people at least did not oppose to this. The most interesting parts are > > at the top and bottom. The middle is just boring conversion, usually > > one option per patch. > > I'm very much for this, and have skimmed it (but not stress tested) and > it looks good to me. I have some WIP patches to --abbrev that conflict, > but which will be simpler as a result of this. I like the series a lot.