[61/76] diff.c: convert -S|-G

Message ID	20190117130615.18732-62-pclouds@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> To: git@vger.kernel.org Cc: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> Subject: [PATCH 61/76] diff.c: convert -S\|-G Date: Thu, 17 Jan 2019 20:06:00 +0700 Message-Id: <20190117130615.18732-62-pclouds@gmail.com> In-Reply-To: <20190117130615.18732-1-pclouds@gmail.com> References: <20190117130615.18732-1-pclouds@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk
Series	Convert diff opt parser to parse_options() \| expand [00/76] Convert diff opt parser to parse_options() [01/76] parse-options.h: remove extern on function prototypes [02/76] parse-options: add one-shot mode [03/76] parse-options: allow keep-unknown + stop-at-non-opt combination [04/76] parse-options: disable option abbreviation with PARSE_OPT_KEEP_UNKNOWN [05/76] parse-options: add OPT_BITOP() [06/76] parse-options: stop abusing 'callback' for lowlevel callbacks [07/76] parse-options: avoid magic return codes [08/76] parse-options: allow ll_callback with OPTION_CALLBACK [09/76] diff.h: keep forward struct declarations sorted [10/76] diff.h: avoid bit fields in struct diff_flags [11/76] diff.c: prepare to use parse_options() for parsing [12/76] diff.c: convert -u\|-p\|--patch [13/76] diff.c: convert -U\|--unified [14/76] diff.c: convert -W\|--[no-]function-context [15/76] diff.c: convert --raw [16/76] diff.c: convert --patch-with-raw [17/76] diff.c: convert --numstat and --shortstat [18/76] diff.c: convert --dirstat and friends [19/76] diff.c: convert --check [20/76] diff.c: convert --summary [21/76] diff.c: convert --patch-with-stat [22/76] diff.c: convert --name-only [23/76] diff.c: convert --name-status [24/76] diff.c: convert -s\|--no-patch [25/76] diff.c: convert --stat* [26/76] diff.c: convert --[no-]compact-summary [27/76] diff.c: convert --output-* [28/76] diff.c: convert -B\|--break-rewrites [29/76] diff.c: convert -M\|--find-renames [30/76] diff.c: convert -D\|--irreversible-delete [31/76] diff.c: convert -C\|--find-copies [32/76] diff.c: convert --find-copies-harder [33/76] diff.c: convert --no-renames\|--[no--rename-empty [34/76] diff.c: convert --relative [35/76] diff.c: convert --[no-]minimal [36/76] diff.c: convert --ignore-some-changes [37/76] diff.c: convert --[no-]indent-heuristic [38/76] diff.c: convert --patience [39/76] diff.c: convert --histogram [40/76] diff.c: convert --diff-algorithm [41/76] diff.c: convert --anchored [42/76] diff.c: convert --binary [43/76] diff.c: convert --full-index [44/76] diff.c: convert -a\|--text [45/76] diff.c: convert -R [46/76] diff.c: convert --[no-]follow [47/76] diff.c: convert --[no-]color [48/76] diff.c: convert --word-diff [49/76] diff.c: convert --word-diff-regex [50/76] diff.c: convert --color-words [51/76] diff.c: convert --exit-code [52/76] diff.c: convert --quiet [53/76] diff.c: convert --ext-diff [54/76] diff.c: convert --textconv [55/76] diff.c: convert --ignore-submodules [56/76] diff.c: convert --submodule [57/76] diff.c: convert --ws-error-highlight [58/76] diff.c: convert --ita-[in]visible-in-index [59/76] diff.c: convert -z [60/76] diff.c: convert -l [61/76] diff.c: convert -S\|-G [62/76] diff.c: convert --pickaxe-all\|--pickaxe-regex [63/76] diff.c: convert -O [64/76] diff.c: convert --find-object [65/76] diff.c: convert --diff-filter [66/76] diff.c: convert --[no-]abbrev [67/76] diff.c: convert --[src\|dst]-prefix [68/76] diff.c: convert --line-prefix [69/76] diff.c: convert --no-prefix [70/76] diff.c: convert --inter-hunk-context [71/76] diff.c: convert --color-moved [72/76] diff.c: convert --color-moved-ws [73/76] diff.c: allow --no-color-moved-ws [74/76] range-diff: use parse_options() instead of diff_opt_parse() [75/76] diff --no-index: use parse_options() instead of diff_opt_parse() [76/76] am: avoid diff_opt_parse()

Message ID

20190117130615.18732-62-pclouds@gmail.com (mailing list archive)

State

New, archived

Headers

From: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?=  <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?=  <pclouds@gmail.com>
Subject: [PATCH 61/76] diff.c: convert -S|-G
Date: Thu, 17 Jan 2019 20:06:00 +0700
Message-Id: <20190117130615.18732-62-pclouds@gmail.com>
In-Reply-To: <20190117130615.18732-1-pclouds@gmail.com>
References: <20190117130615.18732-1-pclouds@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

Convert diff opt parser to parse_options() | expand

Commit Message

Duy Nguyen Jan. 17, 2019, 1:06 p.m. UTC

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 diff.c | 37 ++++++++++++++++++++++++++++---------
 1 file changed, 28 insertions(+), 9 deletions(-)

diff --git a/diff.c b/diff.c
index 00a56a25e0..832a5bcd31 100644
--- a/diff.c
+++ b/diff.c
@@ -5060,6 +5060,28 @@  static int diff_opt_patience(const struct option *opt,
 	return 0;
 }
 
+static int diff_opt_pickaxe_regex(const struct option *opt,
+				  const char *arg, int unset)
+{
+	struct diff_options *options = opt->value;
+
+	BUG_ON_OPT_NEG(unset);
+	options->pickaxe = arg;
+	options->pickaxe_opts |= DIFF_PICKAXE_KIND_G;
+	return 0;
+}
+
+static int diff_opt_pickaxe_string(const struct option *opt,
+				   const char *arg, int unset)
+{
+	struct diff_options *options = opt->value;
+
+	BUG_ON_OPT_NEG(unset);
+	options->pickaxe = arg;
+	options->pickaxe_opts |= DIFF_PICKAXE_KIND_S;
+	return 0;
+}
+
 static int diff_opt_relative(const struct option *opt,
 			     const char *arg, int unset)
 {
@@ -5367,6 +5389,12 @@  static void prep_parse_options(struct diff_options *options)
 		OPT_SET_INT_F(0, "ita-visible-in-index", &options->ita_invisible_in_index,
 			      N_("treat 'git add -N' entries as real in the index"),
 			      0, PARSE_OPT_NONEG),
+		OPT_CALLBACK_F('S', NULL, options, N_("<string>"),
+			       N_("look for differences that change the number of occurrences of the specified string"),
+			       0, diff_opt_pickaxe_string),
+		OPT_CALLBACK_F('G', NULL, options, N_("<regex>"),
+			       N_("look for differences that change the number of occurrences of the specified regex"),
+			       0, diff_opt_pickaxe_regex),
 		{ OPTION_CALLBACK, 0, "output", options, N_("<file>"),
 		  N_("Output to a specific file"),
 		  PARSE_OPT_NONEG, NULL, 0, diff_opt_output },
@@ -5419,15 +5447,6 @@  int diff_opt_parse(struct diff_options *options,
 	}
 
 	/* misc options */
-	else if ((argcount = short_opt('S', av, &optarg))) {
-		options->pickaxe = optarg;
-		options->pickaxe_opts |= DIFF_PICKAXE_KIND_S;
-		return argcount;
-	} else if ((argcount = short_opt('G', av, &optarg))) {
-		options->pickaxe = optarg;
-		options->pickaxe_opts |= DIFF_PICKAXE_KIND_G;
-		return argcount;
-	}
 	else if (!strcmp(arg, "--pickaxe-all"))
 		options->pickaxe_opts |= DIFF_PICKAXE_ALL;
 	else if (!strcmp(arg, "--pickaxe-regex"))

[61/76] diff.c: convert -S|-G

Commit Message

Patch