[21/41] unpack-objects.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status

Commit Message

Elia Pinto March 21, 2022, 10:55 p.m. UTC

The C standard specifies two constants, EXIT_SUCCESS and  EXIT_FAILURE, that may
be  passed  to exit() to indicate successful or unsuccessful termination,
respectively. The value of status in exit(status) may be EXIT_SUCCESS,
EXIT_FAILURE, or any other value, though only the least significant 8 bits (that
is, status & 0377) shall be available to a waiting parent proces. So exit(-1)
return 255.

Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit
status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the
value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for
consistency.

Signed-off-by: Elia Pinto <[e-mail]>
---
 builtin/unpack-objects.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Patch

diff --git a/builtin/unpack-objects.c b/builtin/unpack-objects.c
index dbeb0680a5..d5838bfad1 100644
--- a/builtin/unpack-objects.c
+++ b/builtin/unpack-objects.c
@@ -118,7 +118,7 @@  static void *get_data(unsigned long size)
 			error("inflate returned %d", ret);
 			FREE_AND_NULL(buf);
 			if (!recover)
-				exit(1);
+				exit(EXIT_FAILURE);
 			has_errors = 1;
 			break;
 		}
@@ -435,7 +435,7 @@  static void unpack_delta_entry(enum object_type type, unsigned long delta_size,
 		error("failed to read delta-pack base object %s",
 		      oid_to_hex(&base_oid));
 		if (!recover)
-			exit(1);
+			exit(EXIT_FAILURE);
 		has_errors = 1;
 		return;
 	}
@@ -482,7 +482,7 @@  static void unpack_one(unsigned nr)
 		has_errors = 1;
 		if (recover)
 			return;
-		exit(1);
+		exit(EXIT_FAILURE);
 	}
 }