diff mbox series

[32/41] remote-curl.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status

Message ID 20220321225523.724509-33-gitter.spiros@gmail.com (mailing list archive)
State New, archived
Headers show
Series use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status | expand

Commit Message

Elia Pinto March 21, 2022, 10:55 p.m. UTC 
The C standard specifies two constants, EXIT_SUCCESS and  EXIT_FAILURE, that may
be  passed  to exit() to indicate successful or unsuccessful termination,
respectively. The value of status in exit(status) may be EXIT_SUCCESS,
EXIT_FAILURE, or any other value, though only the least significant 8 bits (that
is, status & 0377) shall be available to a waiting parent proces. So exit(-1)
return 255.

Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit
status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the
value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for
consistency.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 remote-curl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/remote-curl.c b/remote-curl.c
index ff44f41011..da61168c6f 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -1063,7 +1063,7 @@  static int rpc_service(struct rpc_state *rpc, struct discovery *heads,
 	client.git_cmd = 1;
 	strvec_pushv(&client.args, client_argv);
 	if (start_command(&client))
-		exit(1);
+		exit(EXIT_FAILURE);
 	write_or_die(client.in, preamble->buf, preamble->len);
 	if (heads)
 		write_or_die(client.in, heads->buf, heads->len);