diff mbox series

[v2,1/6] Makefile: regenerate perl/build/* if GIT-PERL-DEFINES changes

Message ID patch-1.6-8b899364916-20210510T104937Z-avarab@gmail.com (mailing list archive)
State New, archived
Headers show
Series Makefile/perl: correctly re-generate build/* + speed up under NO_GETTEXT=Y | expand

Commit Message

Ævar Arnfjörð Bjarmason May 10, 2021, 10:50 a.m. UTC
Change the logic to generate perl/build/* to regenerate those files if
GIT-PERL-DEFINES changes. This ensures that e.g. changing localedir
will result in correctly re-generated files.

I don't think that ever worked. The brokenness pre-dates my
20d2a30f8ff (Makefile: replace perl/Makefile.PL with simple make
rules, 2017-12-10).

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 93664d67146..ad618cea33f 100644
--- a/Makefile
+++ b/Makefile
@@ -2675,7 +2675,7 @@  endif
 NO_PERL_CPAN_FALLBACKS_SQ = $(subst ','\'',$(NO_PERL_CPAN_FALLBACKS))
 endif
 
-perl/build/lib/%.pm: perl/%.pm
+perl/build/lib/%.pm: perl/%.pm GIT-PERL-DEFINES
 	$(QUIET_GEN)mkdir -p $(dir $@) && \
 	sed -e 's|@@LOCALEDIR@@|$(perl_localedir_SQ)|g' \
 	    -e 's|@@NO_PERL_CPAN_FALLBACKS@@|$(NO_PERL_CPAN_FALLBACKS_SQ)|g' \