diff mbox series

[v2,2/6] Makefile: don't re-define PERL_DEFINES

Message ID patch-2.6-c15887bbc93-20210510T104937Z-avarab@gmail.com (mailing list archive)
State New, archived
Headers show
Series Makefile/perl: correctly re-generate build/* + speed up under NO_GETTEXT=Y | expand

Commit Message

Ævar Arnfjörð Bjarmason May 10, 2021, 10:50 a.m. UTC 
Since 07d90eadb50 (Makefile: add Perl runtime prefix support,
2018-04-10) we have been declaring PERL_DEFINES right after assigning
to it, with the effect that the first PERL_DEFINES was ignored.

This didn't matter in practice since the first line had all the same
variables as the second, so we'd correctly re-generate everything. It
just made for confusing reading. Let's remove that first assignment.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Makefile | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index ad618cea33f..ea387b431e1 100644
--- a/Makefile
+++ b/Makefile
@@ -2270,8 +2270,6 @@  perl_localedir_SQ = $(localedir_SQ)
 
 ifndef NO_PERL
 PERL_HEADER_TEMPLATE = perl/header_templates/fixed_prefix.template.pl
-PERL_DEFINES = $(PERL_PATH_SQ):$(PERLLIB_EXTRA_SQ):$(perllibdir_SQ)
-
 PERL_DEFINES := $(PERL_PATH_SQ) $(PERLLIB_EXTRA_SQ) $(perllibdir_SQ)
 PERL_DEFINES += $(RUNTIME_PREFIX)