| Message ID | patch-v2-10.21-c99c59dcc57-20211016T093845Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 096a7fbb97dc4015c97b1811aab4e08e2f0ac724 |
| Headers | show |
| Series | refs: stop having the API set "errno" | expand |
diff --git a/refs/files-backend.c b/refs/files-backend.c index 482d04de03a..759c21e88ae 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -280,10 +280,11 @@ static void loose_fill_ref_dir(struct ref_store *ref_store, create_dir_entry(dir->cache, refname.buf, refname.len)); } else { - if (!refs_resolve_ref_unsafe(&refs->base, + int ignore_errno; + if (!refs_werrres_ref_unsafe(&refs->base, refname.buf, RESOLVE_REF_READING, - &oid, &flag)) { + &oid, &flag, &ignore_errno)) { oidclr(&oid); flag |= REF_ISBROKEN; } else if (is_null_oid(&oid)) {
Change the refs_resolve_ref_unsafe() invoked in loose_fill_ref_dir() to a form that ignores errno. The only eventual caller of this function is create_ref_cache(), whose callers in turn don't have their failure depend on any errno set here. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- refs/files-backend.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)