diff mbox series

[v4,23/36] am: convert 'post-rewrite' hook to hook.h

Message ID	patch-v4-23.36-7d1925cca48-20210803T191505Z-avarab@gmail.com (mailing list archive)
State	Superseded
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= <avarab@gmail.com> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Emily Shaffer <emilyshaffer@google.com>, Jeff King <peff@peff.net>, Taylor Blau <me@ttaylorr.com>, Felipe Contreras <felipe.contreras@gmail.com>, Eric Sunshine <sunshine@sunshineco.com>, "brian m . carlson" <sandals@crustytoothpaste.net>, Josh Steadmon <steadmon@google.com>, Jonathan Tan <jonathantanmy@google.com>, Derrick Stolee <stolee@gmail.com>, =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFy?= =?utf-8?b?bWFzb24=?= <avarab@gmail.com> Subject: [PATCH v4 23/36] am: convert 'post-rewrite' hook to hook.h Date: Tue, 3 Aug 2021 21:38:49 +0200 Message-Id: <patch-v4-23.36-7d1925cca48-20210803T191505Z-avarab@gmail.com> In-Reply-To: <cover-v4-00.36-00000000000-20210803T191505Z-avarab@gmail.com> References: <cover-00.27-0000000000-20210617T101216Z-avarab@gmail.com> <cover-v4-00.36-00000000000-20210803T191505Z-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Run hooks via "git run hook" & hook library \| expand [v4,00/36] Run hooks via "git run hook" & hook library [v4,01/36] Makefile: mark "check" target as .PHONY [v4,02/36] Makefile: stop hardcoding {command,config}-list.h [v4,03/36] Makefile: remove an out-of-date comment [v4,04/36] hook.[ch]: move find_hook() to this new library [v4,05/36] hook.c: add a hook_exists() wrapper and use it in bugreport.c [v4,06/36] hook.c users: use "hook_exists()" insted of "find_hook()" [v4,07/36] hook-list.h: add a generated list of hooks, like config-list.h [v4,08/36] hook: add 'run' subcommand [v4,09/36] gc: use hook library for pre-auto-gc hook [v4,10/36] rebase: convert pre-rebase to use hook.h [v4,11/36] am: convert applypatch to use hook.h [v4,12/36] hooks: convert 'post-checkout' hook to hook library [v4,13/36] merge: convert post-merge to use hook.h [v4,14/36] git hook run: add an --ignore-missing flag [v4,15/36] send-email: use 'git hook run' for 'sendemail-validate' [v4,16/36] git-p4: use 'git hook' to run hooks [v4,17/36] commit: convert {pre-commit,prepare-commit-msg} hook to hook.h [v4,18/36] read-cache: convert post-index-change to use hook.h [v4,19/36] receive-pack: convert push-to-checkout hook to hook.h [v4,20/36] run-command: remove old run_hook_{le,ve}() hook API [v4,21/36] run-command: allow stdin for run_processes_parallel [v4,22/36] hook: support passing stdin to hooks [v4,23/36] am: convert 'post-rewrite' hook to hook.h [v4,24/36] run-command: add stdin callback for parallelization [v4,25/36] hook: provide stdin by string_list or callback [v4,26/36] hook: convert 'post-rewrite' hook in sequencer.c to hook.h [v4,27/36] transport: convert pre-push hook to hook.h [v4,28/36] hook tests: test for exact "pre-push" hook input [v4,29/36] hook tests: use a modern style for "pre-push" tests [v4,30/36] reference-transaction: use hook.h to run hooks [v4,31/36] run-command: allow capturing of collated output [v4,32/36] hooks: allow callers to capture output [v4,33/36] receive-pack: convert 'update' hook to hook.h [v4,34/36] post-update: use hook.h library [v4,35/36] receive-pack: convert receive hooks to hook.h [v4,36/36] hooks: fix a TOCTOU in "did we run a hook?" heuristic

Commit Message

Ævar Arnfjörð Bjarmason Aug. 3, 2021, 7:38 p.m. UTC

From: Emily Shaffer <emilyshaffer@google.com>

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 builtin/am.c | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff mbox series

Patch

diff --git a/builtin/am.c b/builtin/am.c
index e444b18b64a..9e3d4d9ab44 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -467,24 +467,12 @@  static int run_applypatch_msg_hook(struct am_state *state)
  */
 static int run_post_rewrite_hook(const struct am_state *state)
 {
-	struct child_process cp = CHILD_PROCESS_INIT;
-	const char *hook = find_hook("post-rewrite");
-	int ret;
-
-	if (!hook)
-		return 0;
-
-	strvec_push(&cp.args, hook);
-	strvec_push(&cp.args, "rebase");
-
-	cp.in = xopen(am_path(state, "rewritten"), O_RDONLY);
-	cp.stdout_to_stderr = 1;
-	cp.trace2_hook_name = "post-rewrite";
+	struct run_hooks_opt opt = RUN_HOOKS_OPT_INIT;
 
-	ret = run_command(&cp);
+	strvec_push(&opt.args, "rebase");
+	opt.path_to_stdin = am_path(state, "rewritten");
 
-	close(cp.in);
-	return ret;
+	return run_hooks_oneshot("post-rewrite", &opt);
 }
 
 /**