mbox series

[0/3] Make DRM DSC helpers more generally usable

Message ID 20190213144536.21661-1-David.Francis@amd.com (mailing list archive)
Headers show
Series Make DRM DSC helpers more generally usable | expand

Message

Francis, David Feb. 13, 2019, 2:45 p.m. UTC 
drm_dsc could use some work so that drm drivers other than
i915 can make use of it their own DSC implementations

Move rc compute, a function that forms part of the DSC spec,
into drm. Update it to DSC 1.2. Also change the packing function
to operate only on the packing struct, to allow for drivers with
their own SDP struct headers

David Francis (3):
  drm/i915: Move dsc rate params compute into drm
  drm/dsc: Add native 420 and 422 support to compute_rc_params
  drm/dsc: Change infoframe_pack to payload_pack

 drivers/gpu/drm/drm_dsc.c         | 236 ++++++++++++++++++++++++------
 drivers/gpu/drm/i915/intel_vdsc.c | 131 +----------------
 include/drm/drm_dsc.h             |   7 +-
 3 files changed, 200 insertions(+), 174 deletions(-)

Comments

Jani Nikula Feb. 14, 2019, 1:09 p.m. UTC | #1 
On Wed, 13 Feb 2019, David Francis <David.Francis@amd.com> wrote:
> drm_dsc could use some work so that drm drivers other than
> i915 can make use of it their own DSC implementations
>
> Move rc compute, a function that forms part of the DSC spec,
> into drm. Update it to DSC 1.2. Also change the packing function
> to operate only on the packing struct, to allow for drivers with
> their own SDP struct headers

Acked-by: Jani Nikula <jani.nikula@intel.com>

as long as you've ironed out the details with Manasi's review. Also okay
to merge via drm-misc.

Ideally, please rebase on drm-tip and continue to Cc: intel-gfx so the
Intel CI machinery can crunch through this. Now the patches failed to
apply.

Thanks,
Jani.



>
> David Francis (3):
>   drm/i915: Move dsc rate params compute into drm
>   drm/dsc: Add native 420 and 422 support to compute_rc_params
>   drm/dsc: Change infoframe_pack to payload_pack
>
>  drivers/gpu/drm/drm_dsc.c         | 236 ++++++++++++++++++++++++------
>  drivers/gpu/drm/i915/intel_vdsc.c | 131 +----------------
>  include/drm/drm_dsc.h             |   7 +-
>  3 files changed, 200 insertions(+), 174 deletions(-)