mbox series

[v2,00/14] drm/i915/fbc: Fix FBC for glk+

Message ID 20191127201222.16669-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915/fbc: Fix FBC for glk+ | expand

Message

Ville Syrjälä Nov. 27, 2019, 8:12 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

CI got hopelessly confused with the v1 series so reposting in its
entirety.

I also slapped on an extra patch at the end which should hopefully
avoid the problems with FBC not getting enabled with fastboot.

Force pushed to
git://github.com/vsyrjala/linux.git glk_fbc_wa

Cc: Daniel Drake <drake@endlessm.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Jian-Hong Pan <jian-hong@endlessm.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Ville Syrjälä (14):
  drm/i915/fbc: Disable fbc by default on all glk+
  drm/i915/fbc: Nuke bogus single pipe fbc1 restriction
  drm/i915: Relocate intel_crtc_active()
  drm/i915/fbc: Remove the FBC_RT_BASE setup for ILK/SNB
  drm/i915/fbc: Precompute gen9 cfb stride w/a
  drm/i915/fbc: Track plane visibility
  drm/i915/fbc: Store fence_id direction in fbc cache/params
  drm/i915/fbc: Make fence_id optional for i965gm
  drm/i915/fbc: s/gen9 && !glk/gen9_bc || bxt/
  drm/i915/fbc: Nuke fbc.enabled
  drm/i915/fbc: Start using flip nuke
  drm/i915/fbc: Wait for vblank after FBC disable on glk+
  drm/i915/fbc: Enable fbc by default on glk+ once again
  drm/i915/fbc: Reallocate cfb if we need more of it

 drivers/gpu/drm/i915/display/intel_display.c |  25 +-
 drivers/gpu/drm/i915/display/intel_display.h |   1 -
 drivers/gpu/drm/i915/display/intel_fbc.c     | 274 ++++++++++---------
 drivers/gpu/drm/i915/display/intel_fbc.h     |   3 +-
 drivers/gpu/drm/i915/i915_drv.h              |  14 +-
 drivers/gpu/drm/i915/intel_pm.c              |  19 ++
 6 files changed, 169 insertions(+), 167 deletions(-)

Comments

Daniel Drake Nov. 28, 2019, 1:33 a.m. UTC | #1
On Thu, Nov 28, 2019 at 4:12 AM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
> I also slapped on an extra patch at the end which should hopefully
> avoid the problems with FBC not getting enabled with fastboot.

Retested Asus E406MA, default parameters (fastboot=1) and now FBC is
marked enabled in i915_fbc_status.
I can't reproduce the visual corruption using my original tests
(interacting with GNOME gdm login screen, frantically scrolling text
inside gnome-terminal).

Tested-by: Daniel Drake <drake@endlessm.com>

Thanks!