| Message ID | 20211104144520.22605-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915/fbc: Prep work for multiple FBC instances | expand |
On Thu, 04 Nov 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Bunch of refactoring and cleanups, mainly as prep work > for introducing multiple FBC instances in the future. Eyeballed through the series, and I like all of it. Really nice. Acked-by: Jani Nikula <jani.nikula@intel.com> > > Ville Syrjälä (17): > drm/i915/fbc: Exract snb_fbc_program_fence() > drm/i915/fbc: Extract {skl,glk}_fbc_program_cfb_stride() > drm/i915/fbc: Just use params->fence_y_offset always > drm/i915/fbc: Introduce intel_fbc_is_compressing() > drm/i915/fbc: Extract helpers to compute FBC control register values > drm/i915/fbc: Introduce intel_fbc_funcs > drm/i915/fbc: Introduce .nuke() vfunc > drm/i915/fbc: s/gen7/ivb/ > drm/i915/fbc: Introduce .program_cfb() vfunc > drm/i915/fbc: Introduce intel_fbc_set_false_color() > drm/i915/fbc: Nuke BDW_FBC_COMP_SEG_MASK > drm/i915/fbc: Clean up all register defines > drm/i915/fbc: Finish polishing FBC1 registers > drm/i915: Relocate FBC_LLC_READ_CTRL > drm/i915/fbc: s/dev_priv/i915/ > drm/i915/fbc: Start passing around intel_fbc > drm/1915/fbc: Replace plane->has_fbc with a pointer to the fbc > instance > > drivers/gpu/drm/i915/display/i9xx_plane.c | 10 +- > drivers/gpu/drm/i915/display/intel_display.c | 4 +- > .../drm/i915/display/intel_display_debugfs.c | 43 +- > .../drm/i915/display/intel_display_types.h | 4 +- > drivers/gpu/drm/i915/display/intel_fbc.c | 996 ++++++++++-------- > drivers/gpu/drm/i915/display/intel_fbc.h | 11 +- > .../drm/i915/display/intel_fifo_underrun.c | 2 +- > .../drm/i915/display/skl_universal_plane.c | 10 +- > drivers/gpu/drm/i915/i915_drv.h | 4 + > drivers/gpu/drm/i915/i915_reg.h | 154 +-- > drivers/gpu/drm/i915/intel_pm.c | 16 +- > 11 files changed, 695 insertions(+), 559 deletions(-)
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani > Nikula > Sent: Friday, November 5, 2021 3:09 PM > To: Ville Syrjala <ville.syrjala@linux.intel.com>; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 00/17] drm/i915/fbc: Prep work for multiple FBC > instances > > On Thu, 04 Nov 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Bunch of refactoring and cleanups, mainly as prep work for introducing > > multiple FBC instances in the future. > > Eyeballed through the series, and I like all of it. Really nice. > > Acked-by: Jani Nikula <jani.nikula@intel.com> The series looks ok to me. For the series Reviewed-by: Mika Kahola <mika.kahola@intel.com> > > > > > Ville Syrjälä (17): > > drm/i915/fbc: Exract snb_fbc_program_fence() > > drm/i915/fbc: Extract {skl,glk}_fbc_program_cfb_stride() > > drm/i915/fbc: Just use params->fence_y_offset always > > drm/i915/fbc: Introduce intel_fbc_is_compressing() > > drm/i915/fbc: Extract helpers to compute FBC control register values > > drm/i915/fbc: Introduce intel_fbc_funcs > > drm/i915/fbc: Introduce .nuke() vfunc > > drm/i915/fbc: s/gen7/ivb/ > > drm/i915/fbc: Introduce .program_cfb() vfunc > > drm/i915/fbc: Introduce intel_fbc_set_false_color() > > drm/i915/fbc: Nuke BDW_FBC_COMP_SEG_MASK > > drm/i915/fbc: Clean up all register defines > > drm/i915/fbc: Finish polishing FBC1 registers > > drm/i915: Relocate FBC_LLC_READ_CTRL > > drm/i915/fbc: s/dev_priv/i915/ > > drm/i915/fbc: Start passing around intel_fbc > > drm/1915/fbc: Replace plane->has_fbc with a pointer to the fbc > > instance > > > > drivers/gpu/drm/i915/display/i9xx_plane.c | 10 +- > > drivers/gpu/drm/i915/display/intel_display.c | 4 +- > > .../drm/i915/display/intel_display_debugfs.c | 43 +- > > .../drm/i915/display/intel_display_types.h | 4 +- > > drivers/gpu/drm/i915/display/intel_fbc.c | 996 ++++++++++-------- > > drivers/gpu/drm/i915/display/intel_fbc.h | 11 +- > > .../drm/i915/display/intel_fifo_underrun.c | 2 +- > > .../drm/i915/display/skl_universal_plane.c | 10 +- > > drivers/gpu/drm/i915/i915_drv.h | 4 + > > drivers/gpu/drm/i915/i915_reg.h | 154 +-- > > drivers/gpu/drm/i915/intel_pm.c | 16 +- > > 11 files changed, 695 insertions(+), 559 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center
From: Ville Syrjälä <ville.syrjala@linux.intel.com> Bunch of refactoring and cleanups, mainly as prep work for introducing multiple FBC instances in the future. Ville Syrjälä (17): drm/i915/fbc: Exract snb_fbc_program_fence() drm/i915/fbc: Extract {skl,glk}_fbc_program_cfb_stride() drm/i915/fbc: Just use params->fence_y_offset always drm/i915/fbc: Introduce intel_fbc_is_compressing() drm/i915/fbc: Extract helpers to compute FBC control register values drm/i915/fbc: Introduce intel_fbc_funcs drm/i915/fbc: Introduce .nuke() vfunc drm/i915/fbc: s/gen7/ivb/ drm/i915/fbc: Introduce .program_cfb() vfunc drm/i915/fbc: Introduce intel_fbc_set_false_color() drm/i915/fbc: Nuke BDW_FBC_COMP_SEG_MASK drm/i915/fbc: Clean up all register defines drm/i915/fbc: Finish polishing FBC1 registers drm/i915: Relocate FBC_LLC_READ_CTRL drm/i915/fbc: s/dev_priv/i915/ drm/i915/fbc: Start passing around intel_fbc drm/1915/fbc: Replace plane->has_fbc with a pointer to the fbc instance drivers/gpu/drm/i915/display/i9xx_plane.c | 10 +- drivers/gpu/drm/i915/display/intel_display.c | 4 +- .../drm/i915/display/intel_display_debugfs.c | 43 +- .../drm/i915/display/intel_display_types.h | 4 +- drivers/gpu/drm/i915/display/intel_fbc.c | 996 ++++++++++-------- drivers/gpu/drm/i915/display/intel_fbc.h | 11 +- .../drm/i915/display/intel_fifo_underrun.c | 2 +- .../drm/i915/display/skl_universal_plane.c | 10 +- drivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/i915_reg.h | 154 +-- drivers/gpu/drm/i915/intel_pm.c | 16 +- 11 files changed, 695 insertions(+), 559 deletions(-)