mbox series

[v2,0/3] drm/i915: A couple of if/else ladder refactors

Message ID 20220908-if-ladder-v2-0-7a7b15545c93@intel.com (mailing list archive)
Headers show
Series drm/i915: A couple of if/else ladder refactors | expand

Message

Lucas De Marchi Sept. 13, 2022, 9:09 p.m. UTC
Refactor code to follow the same convention as last platform first.  This
series includes one patch that had already been reviewed, for frequency read
and 2 more refactors.

v2: Fix patch 2 not considering intel_gt_check_clock_frequency() call to read
frequency (Gustavo)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
Lucas De Marchi (3):
      drm/i915: Invert if/else ladder for frequency read
      drm/i915/gt: Extract per-platform function for frequency read
      drm/i915: Invert if/else ladder for stolen init

 drivers/gpu/drm/i915/gem/i915_gem_stolen.c     |  51 +++-----
 drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c | 174 ++++++++++++-------------
 2 files changed, 97 insertions(+), 128 deletions(-)
---
base-commit: 088771790e5d121c70c358468abbebb4710eb02f
change-id: 20220908-if-ladder-df33a06d4f4e

Best regards,

Comments

Lucas De Marchi Sept. 14, 2022, 10:13 p.m. UTC | #1
On Wed, Sep 14, 2022 at 03:34:12PM +0000, Patchwork wrote:
>== Series Details ==
>
>Series: drm/i915: A couple of if/else ladder refactors (rev2)
>URL   : https://patchwork.freedesktop.org/series/108315/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_12132_full -> Patchwork_108315v2_full
>====================================================
>
>Summary
>-------
>
>  **FAILURE**
>
>  Serious unknown changes coming with Patchwork_108315v2_full absolutely need to be
>  verified manually.
>
>  If you think the reported changes have nothing to do with the changes
>  introduced in Patchwork_108315v2_full, please notify your bug team to allow them
>  to document this new failure mode, which will reduce false positives in CI.
>
>
>
>Participating hosts (11 -> 11)
>------------------------------
>
>  No changes in participating hosts
>
>Possible new issues
>-------------------
>
>  Here are the unknown changes that may have been introduced in Patchwork_108315v2_full:
>
>### IGT changes ###
>
>#### Possible regressions ####
>
>  * igt@gen9_exec_parse@bb-large:
>    - shard-apl:          [PASS][1] -> [TIMEOUT][2]
>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12132/shard-apl1/igt@gen9_exec_parse@bb-large.html
>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108315v2/shard-apl2/igt@gen9_exec_parse@bb-large.html
>

unrelated to this change and also failed recently in drm-tip:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12131/shard-apl7/igt@gen9_exec_parse@bb-large.html

pushed, thanks for reviews.

Lucas De Marchi