[0/4] drm/i915/cdclk: improve abstractions

Message

Jani Nikula Dec. 9, 2021, 4:51 p.m. UTC

Clean up the cdclk header dependencies.

Jani Nikula (4):
  drm/i915/cdclk: move intel_atomic_check_cdclk() to intel_cdclk.c
  drm/i915/cdclk: un-inline intel_cdclk_state functions
  drm/i915/cdclk: hide struct intel_cdclk_vals
  drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency

 drivers/gpu/drm/i915/display/intel_atomic.c  |  1 +
 drivers/gpu/drm/i915/display/intel_cdclk.c   | 81 +++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_cdclk.h   | 26 +++----
 drivers/gpu/drm/i915/display/intel_display.c | 55 +------------
 drivers/gpu/drm/i915/i915_drv.h              |  6 +-
 5 files changed, 96 insertions(+), 73 deletions(-)

Comments

Ville Syrjälä Dec. 9, 2021, 5:57 p.m. UTC | #1

On Thu, Dec 09, 2021 at 06:51:21PM +0200, Jani Nikula wrote:
> Clean up the cdclk header dependencies.
> 
> Jani Nikula (4):
>   drm/i915/cdclk: move intel_atomic_check_cdclk() to intel_cdclk.c
>   drm/i915/cdclk: un-inline intel_cdclk_state functions
>   drm/i915/cdclk: hide struct intel_cdclk_vals
>   drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency

Another low hanging fruit would be to move struct intel_cdclk_funcs
definition into intel_cdclk.c.

> 
>  drivers/gpu/drm/i915/display/intel_atomic.c  |  1 +
>  drivers/gpu/drm/i915/display/intel_cdclk.c   | 81 +++++++++++++++++++-
>  drivers/gpu/drm/i915/display/intel_cdclk.h   | 26 +++----
>  drivers/gpu/drm/i915/display/intel_display.c | 55 +------------
>  drivers/gpu/drm/i915/i915_drv.h              |  6 +-
>  5 files changed, 96 insertions(+), 73 deletions(-)
> 
> -- 
> 2.30.2