| Message ID | 002a8d51244a70572744de86cacbdae293e7d503.1657699522.git.mchehab@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: fix kernel-doc issues | expand |
On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > This file is licensed with MIT license. Change its license text > to use SPDX. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/ > > drivers/gpu/drm/i915/display/dvo_sil164.c | 32 +++++------------------ > 1 file changed, 6 insertions(+), 26 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/dvo_sil164.c b/drivers/gpu/drm/i915/display/dvo_sil164.c > index 0dfa0a0209ff..12974f7c9dc1 100644 > --- a/drivers/gpu/drm/i915/display/dvo_sil164.c > +++ b/drivers/gpu/drm/i915/display/dvo_sil164.c > @@ -1,30 +1,10 @@ > -/************************************************************************** > +// SPDX-License-Identifier: MIT > > -Copyright © 2006 Dave Airlie > - > -All Rights Reserved. > - > -Permission is hereby granted, free of charge, to any person obtaining a > -copy of this software and associated documentation files (the > -"Software"), to deal in the Software without restriction, including > -without limitation the rights to use, copy, modify, merge, publish, > -distribute, sub license, and/or sell copies of the Software, and to > -permit persons to whom the Software is furnished to do so, subject to > -the following conditions: > - > -The above copyright notice and this permission notice (including the > -next paragraph) shall be included in all copies or substantial portions > -of the Software. > - > -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS > -OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > -MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. > -IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR > -ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > -TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > -SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > - > -**************************************************************************/ > +/* > + * Copyright © 2006 Dave Airlie > + * > + * All Rights Reserved. > + */ > > #include "intel_display_types.h" > #include "intel_dvo_dev.h" > -- > 2.36.1 >
On Fri, 2022-07-15 at 17:35 -0400, Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > > This file is licensed with MIT license. Change its license text > > to use SPDX. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Not exactly the MIT license as it's missing "or copyright holders" > > > --- > > > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/ > > > > drivers/gpu/drm/i915/display/dvo_sil164.c | 32 +++++------------------ > > 1 file changed, 6 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/dvo_sil164.c b/drivers/gpu/drm/i915/display/dvo_sil164.c > > index 0dfa0a0209ff..12974f7c9dc1 100644 > > --- a/drivers/gpu/drm/i915/display/dvo_sil164.c > > +++ b/drivers/gpu/drm/i915/display/dvo_sil164.c > > @@ -1,30 +1,10 @@ > > -/************************************************************************** > > +// SPDX-License-Identifier: MIT > > > > -Copyright © 2006 Dave Airlie > > - > > -All Rights Reserved. > > - > > -Permission is hereby granted, free of charge, to any person obtaining a > > -copy of this software and associated documentation files (the > > -"Software"), to deal in the Software without restriction, including > > -without limitation the rights to use, copy, modify, merge, publish, > > -distribute, sub license, and/or sell copies of the Software, and to > > -permit persons to whom the Software is furnished to do so, subject to > > -the following conditions: > > - > > -The above copyright notice and this permission notice (including the > > -next paragraph) shall be included in all copies or substantial portions > > -of the Software. > > - > > -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS > > -OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > -MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. > > -IN NO EVENT SHALL THE AUTHOR Missing "Authors or copyright holders" > > BE LIABLE FOR > > -ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > > -TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > > -SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > - > > -**************************************************************************/ > > +/* > > + * Copyright © 2006 Dave Airlie > > + * > > + * All Rights Reserved. > > + */ > > > > #include "intel_display_types.h" > > #include "intel_dvo_dev.h" > > -- > > 2.36.1 > >
On Fri, 15 Jul 2022 15:16:05 -0700 Joe Perches <joe@perches.com> wrote: > On Fri, 2022-07-15 at 17:35 -0400, Rodrigo Vivi wrote: > > On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > > > This file is licensed with MIT license. Change its license text > > > to use SPDX. > > > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> > > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Not exactly the MIT license as it's missing "or copyright holders" Text is not identical, but the license is... see below: > > > > > --- > > > > > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > > > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/ > > > > > > drivers/gpu/drm/i915/display/dvo_sil164.c | 32 +++++------------------ > > > 1 file changed, 6 insertions(+), 26 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/dvo_sil164.c b/drivers/gpu/drm/i915/display/dvo_sil164.c > > > index 0dfa0a0209ff..12974f7c9dc1 100644 > > > --- a/drivers/gpu/drm/i915/display/dvo_sil164.c > > > +++ b/drivers/gpu/drm/i915/display/dvo_sil164.c > > > @@ -1,30 +1,10 @@ > > > -/************************************************************************** > > > +// SPDX-License-Identifier: MIT > > > > > > -Copyright © 2006 Dave Airlie > > > - > > > -All Rights Reserved. > > > - > > > -Permission is hereby granted, free of charge, to any person obtaining a > > > -copy of this software and associated documentation files (the > > > -"Software"), to deal in the Software without restriction, including > > > -without limitation the rights to use, copy, modify, merge, publish, > > > -distribute, sub license, and/or sell copies of the Software, and to > > > -permit persons to whom the Software is furnished to do so, subject to > > > -the following conditions: > > > - > > > -The above copyright notice and this permission notice (including the > > > -next paragraph) shall be included in all copies or substantial portions > > > -of the Software. The license itself is here. It is standard MIT license. The original text for the above paragraph is clearer about that: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." The "next paragraph", mentioned on this variant: > > > - > > > -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS > > > -OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > > -MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. > > > -IN NO EVENT SHALL THE AUTHOR > > Missing "Authors or copyright holders" Is actually a disclaimer's note, and not the license itself, informing that there's no warranties provide by author(s). With SPDX, this will point to LICENSES/preferred/MIT with has a paragraph that fits to the same purpose: it excludes any express or implied warranties. Btw, the Kernel itself had this at COPYING by the time this was added and before SPDX, which was there when this code was added. This is part of the GPL text: This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. So, I can't see any changes here: with or without this patch, there's no warranties from the ones that wrote the code - nor for any copyright holders - as the Kernel as a hole is released under GPL. Also, LICENSES/preferred/MIT define that MIT license text is: MIT License Copyright (c) <year> <copyright holders> In this specific case, "Copyright © 2006 Dave Airlie", which is both the author and the copyright holder that is part of MIT, so the text meaning is identical with either "AUTHOR" or "AUTHORS OR COPYRIGHT HOLDERS" is used. So, I can't see any difference from legal standpoint. Regards, Mauro
diff --git a/drivers/gpu/drm/i915/display/dvo_sil164.c b/drivers/gpu/drm/i915/display/dvo_sil164.c index 0dfa0a0209ff..12974f7c9dc1 100644 --- a/drivers/gpu/drm/i915/display/dvo_sil164.c +++ b/drivers/gpu/drm/i915/display/dvo_sil164.c @@ -1,30 +1,10 @@ -/************************************************************************** +// SPDX-License-Identifier: MIT -Copyright © 2006 Dave Airlie - -All Rights Reserved. - -Permission is hereby granted, free of charge, to any person obtaining a -copy of this software and associated documentation files (the -"Software"), to deal in the Software without restriction, including -without limitation the rights to use, copy, modify, merge, publish, -distribute, sub license, and/or sell copies of the Software, and to -permit persons to whom the Software is furnished to do so, subject to -the following conditions: - -The above copyright notice and this permission notice (including the -next paragraph) shall be included in all copies or substantial portions -of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS -OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF -MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. -IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR -ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, -TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE -SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. - -**************************************************************************/ +/* + * Copyright © 2006 Dave Airlie + * + * All Rights Reserved. + */ #include "intel_display_types.h" #include "intel_dvo_dev.h"
This file is licensed with MIT license. Change its license text to use SPDX. Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/ drivers/gpu/drm/i915/display/dvo_sil164.c | 32 +++++------------------ 1 file changed, 6 insertions(+), 26 deletions(-)