| Message ID | 20170825182639.3004-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 25, 2017 at 07:26:39PM +0100, Chris Wilson wrote: > To ensure the module exists, first load it. Then when we try to unload > the module (to check that our modprobe interface works), we will not get > spurious failures due to -ENOENT (in this case meaning the module did > not exist): > > (vgem_basic:18361) igt-core-DEBUG: Starting subtest: unload > (vgem_basic:18361) igt-kmod-DEBUG: Could not remove module vgem (No such file or directory) > Test requirement not met in function test_unload, file vgem_basic.c:331: > Test requirement: module_unload() == 0 > Last errno: 2, No such file or directory > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
diff --git a/tests/vgem_basic.c b/tests/vgem_basic.c index 982da73a..1a952c54 100644 --- a/tests/vgem_basic.c +++ b/tests/vgem_basic.c @@ -328,6 +328,10 @@ static void test_unload(void) int vgem, dmabuf; uint32_t *ptr; + /* Load and unload vgem just to make sure it exists */ + vgem = __drm_open_driver(DRIVER_VGEM); + igt_require(vgem != -1); + close(vgem); igt_require(module_unload() == 0); vgem = __drm_open_driver(DRIVER_VGEM);
To ensure the module exists, first load it. Then when we try to unload the module (to check that our modprobe interface works), we will not get spurious failures due to -ENOENT (in this case meaning the module did not exist): (vgem_basic:18361) igt-core-DEBUG: Starting subtest: unload (vgem_basic:18361) igt-kmod-DEBUG: Could not remove module vgem (No such file or directory) Test requirement not met in function test_unload, file vgem_basic.c:331: Test requirement: module_unload() == 0 Last errno: 2, No such file or directory Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- tests/vgem_basic.c | 4 ++++ 1 file changed, 4 insertions(+)