| Message ID | 20180828174146.29894-1-lucas.demarchi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/i915: make field unsigned | expand |
On Wed, Sep 05, 2018 at 09:05:40PM +0000, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915: make field unsigned (rev2) > URL : https://patchwork.freedesktop.org/series/48818/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > c39485603dc4 drm/i915: make field unsigned > 6ee99a76cca9 drm/i915: reword documentation of possible pci_device_id struct > -:33: WARNING:SPACE_BEFORE_TAB: please, no space before tabs > #33: FILE: include/drm/i915_pciids.h:32: > + * ^I__u32 vendor, device;$ > > -:34: WARNING:SPACE_BEFORE_TAB: please, no space before tabs > #34: FILE: include/drm/i915_pciids.h:33: > + * ^I__u32 subvendor, subdevice;$ > > -:35: WARNING:SPACE_BEFORE_TAB: please, no space before tabs > #35: FILE: include/drm/i915_pciids.h:34: > + * ^I__u32 class, class_mask;$ > > -:36: WARNING:SPACE_BEFORE_TAB: please, no space before tabs > #36: FILE: include/drm/i915_pciids.h:35: > + * ^Ikernel_ulong_t driver_data;$ Those are in a comment and the spaces are actually correct since it's part of the multline comment style. Lucas De Marchi
+Chris On Tue, Aug 28, 2018 at 10:41 AM Lucas De Marchi <lucas.demarchi@intel.com> wrote: > > subvendor and subdevice are unsigned, so fix their initialization in > INTEL_VGA_DEVICE. > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- > include/drm/i915_pciids.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index fd965ffbb92e..754ce4b10129 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -37,7 +37,7 @@ > */ > #define INTEL_VGA_DEVICE(id, info) { \ > 0x8086, id, \ > - ~0, ~0, \ > + ~0u, ~0u, \ This came from your suggestion in https://patchwork.freedesktop.org/patch/245943/ "And then while you are there, add the missing 'u' to ~0u" Should I resend this simple patch alone (since the second got nacked)? thanks Lucas De Marchi > 0x030000, 0xff0000, \ > (unsigned long) info } > > -- > 2.17.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index fd965ffbb92e..754ce4b10129 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -37,7 +37,7 @@ */ #define INTEL_VGA_DEVICE(id, info) { \ 0x8086, id, \ - ~0, ~0, \ + ~0u, ~0u, \ 0x030000, 0xff0000, \ (unsigned long) info }
subvendor and subdevice are unsigned, so fix their initialization in INTEL_VGA_DEVICE. Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- include/drm/i915_pciids.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)