diff mbox series

[v2,2/2] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

Message ID 20190620092730.4700-3-lionel.g.landwerlin@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: CTS fixes | expand

Commit Message

Lionel Landwerlin June 20, 2019, 9:27 a.m. UTC
The same tests failing on CFL+ platforms are also failing on ICL.
Documentation doesn't list the
WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but
applying it fixes the same tests as CFL.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Anuj Phogat June 20, 2019, 5:56 p.m. UTC | #1
On Thu, Jun 20, 2019 at 2:27 AM Lionel Landwerlin
<lionel.g.landwerlin@intel.com> wrote:
>
> The same tests failing on CFL+ platforms are also failing on ICL.
> Documentation doesn't list the
> WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but
> applying it fixes the same tests as CFL.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 367f5cc5965f..331a0050154d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1131,6 +1131,12 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)
>
>                 /* WaEnableStateCacheRedirectToCS:icl */
>                 whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
> +
> +               /* WaAllowPMDepthAndInvocationCountAccessFromUMD:icl */
> +               whitelist_reg(w, PS_DEPTH_COUNT);
> +               whitelist_reg(w, PS_DEPTH_COUNT_UDW);
> +               whitelist_reg(w, PS_INVOCATION_COUNT);
> +               whitelist_reg(w, PS_INVOCATION_COUNT_UDW);
>                 break;
>
>         case VIDEO_DECODE_CLASS:
> --
> 2.21.0.392.gf8f6787159e
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Tested-by:  Anuj Phogat <anuj.phogat@gmail.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 367f5cc5965f..331a0050154d 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1131,6 +1131,12 @@  static void icl_whitelist_build(struct intel_engine_cs *engine)
 
 		/* WaEnableStateCacheRedirectToCS:icl */
 		whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
+
+		/* WaAllowPMDepthAndInvocationCountAccessFromUMD:icl */
+		whitelist_reg(w, PS_DEPTH_COUNT);
+		whitelist_reg(w, PS_DEPTH_COUNT_UDW);
+		whitelist_reg(w, PS_INVOCATION_COUNT);
+		whitelist_reg(w, PS_INVOCATION_COUNT_UDW);
 		break;
 
 	case VIDEO_DECODE_CLASS: