| Message ID | 20190625175437.14840-8-lucas.demarchi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Initial support for Tiger Lake | expand |
On 6/25/2019 11:24 PM, Lucas De Marchi wrote: > Current list of PCI IDs for Tiger Lake. > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- > drivers/gpu/drm/i915/i915_pci.c | 1 + > include/drm/i915_pciids.h | 10 ++++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 29d2d6070f81..b758dccf4803 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -866,6 +866,7 @@ static const struct pci_device_id pciidlist[] = { > INTEL_CNL_IDS(&intel_cannonlake_info), > INTEL_ICL_11_IDS(&intel_icelake_11_info), > INTEL_EHL_IDS(&intel_elkhartlake_info), > + INTEL_TGL_12_IDS(&intel_tigerlake_12_info), > {0, 0, 0} > }; > MODULE_DEVICE_TABLE(pci, pciidlist); > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index 6d60ea68c171..ce4c4b5d5ba8 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -582,4 +582,14 @@ > INTEL_VGA_DEVICE(0x4551, info), \ > INTEL_VGA_DEVICE(0x4541, info) > > +/* TGL */ > +#define INTEL_TGL_12_IDS(info) \ > + INTEL_VGA_DEVICE(0x9A49, info), \ > + INTEL_VGA_DEVICE(0x9A40, info), \ > + INTEL_VGA_DEVICE(0x9A59, info), \ > + INTEL_VGA_DEVICE(0x9A60, info), \ > + INTEL_VGA_DEVICE(0x9A68, info), \ > + INTEL_VGA_DEVICE(0x9A70, info), \ > + INTEL_VGA_DEVICE(0x9A78, info) B. Specs index 44455 has display only SKU and its device id 0x9A7F, don't we require this pci device id? > + > #endif /* _I915_PCIIDS_H */ >
On Mon, Jul 08, 2019 at 04:25:19PM +0530, Gupta, Anshuman wrote: > > >On 6/25/2019 11:24 PM, Lucas De Marchi wrote: >>Current list of PCI IDs for Tiger Lake. >> >>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> >>--- >> drivers/gpu/drm/i915/i915_pci.c | 1 + >> include/drm/i915_pciids.h | 10 ++++++++++ >> 2 files changed, 11 insertions(+) >> >>diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c >>index 29d2d6070f81..b758dccf4803 100644 >>--- a/drivers/gpu/drm/i915/i915_pci.c >>+++ b/drivers/gpu/drm/i915/i915_pci.c >>@@ -866,6 +866,7 @@ static const struct pci_device_id pciidlist[] = { >> INTEL_CNL_IDS(&intel_cannonlake_info), >> INTEL_ICL_11_IDS(&intel_icelake_11_info), >> INTEL_EHL_IDS(&intel_elkhartlake_info), >>+ INTEL_TGL_12_IDS(&intel_tigerlake_12_info), >> {0, 0, 0} >> }; >> MODULE_DEVICE_TABLE(pci, pciidlist); >>diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h >>index 6d60ea68c171..ce4c4b5d5ba8 100644 >>--- a/include/drm/i915_pciids.h >>+++ b/include/drm/i915_pciids.h >>@@ -582,4 +582,14 @@ >> INTEL_VGA_DEVICE(0x4551, info), \ >> INTEL_VGA_DEVICE(0x4541, info) >>+/* TGL */ >>+#define INTEL_TGL_12_IDS(info) \ >>+ INTEL_VGA_DEVICE(0x9A49, info), \ >>+ INTEL_VGA_DEVICE(0x9A40, info), \ >>+ INTEL_VGA_DEVICE(0x9A59, info), \ >>+ INTEL_VGA_DEVICE(0x9A60, info), \ >>+ INTEL_VGA_DEVICE(0x9A68, info), \ >>+ INTEL_VGA_DEVICE(0x9A70, info), \ >>+ INTEL_VGA_DEVICE(0x9A78, info) >B. Specs index 44455 has display only SKU and its device id 0x9A7F, >don't we require this pci device id? I wouldn't expect a "display only" device to work with the code we are adding here. So I don't think we should add it. Lucas De Marchi >>+ >> #endif /* _I915_PCIIDS_H */ >>
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 29d2d6070f81..b758dccf4803 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -866,6 +866,7 @@ static const struct pci_device_id pciidlist[] = { INTEL_CNL_IDS(&intel_cannonlake_info), INTEL_ICL_11_IDS(&intel_icelake_11_info), INTEL_EHL_IDS(&intel_elkhartlake_info), + INTEL_TGL_12_IDS(&intel_tigerlake_12_info), {0, 0, 0} }; MODULE_DEVICE_TABLE(pci, pciidlist); diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 6d60ea68c171..ce4c4b5d5ba8 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -582,4 +582,14 @@ INTEL_VGA_DEVICE(0x4551, info), \ INTEL_VGA_DEVICE(0x4541, info) +/* TGL */ +#define INTEL_TGL_12_IDS(info) \ + INTEL_VGA_DEVICE(0x9A49, info), \ + INTEL_VGA_DEVICE(0x9A40, info), \ + INTEL_VGA_DEVICE(0x9A59, info), \ + INTEL_VGA_DEVICE(0x9A60, info), \ + INTEL_VGA_DEVICE(0x9A68, info), \ + INTEL_VGA_DEVICE(0x9A70, info), \ + INTEL_VGA_DEVICE(0x9A78, info) + #endif /* _I915_PCIIDS_H */
Current list of PCI IDs for Tiger Lake. Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/i915_pci.c | 1 + include/drm/i915_pciids.h | 10 ++++++++++ 2 files changed, 11 insertions(+)