| Message ID | 20220321135955.922791-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/gt: fix i915_reg_t initialization | expand |
On Mon, Mar 21, 2022 at 03:59:55PM +0200, Jani Nikula wrote: >The initialization is there only to silence the compiler, but use the >correct initializer for i915_reg_t. > >Cc: Lucas De Marchi <lucas.demarchi@intel.com> >Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Lucas De Marchi >--- > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c >index 6d7ec3bf1f32..5423bfd301ad 100644 >--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c >+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c >@@ -767,7 +767,7 @@ static int mi_set_context(struct i915_request *rq, > if (GRAPHICS_VER(i915) == 7) { > if (num_engines) { > struct intel_engine_cs *signaller; >- i915_reg_t last_reg = {}; /* keep gcc quiet */ >+ i915_reg_t last_reg = INVALID_MMIO_REG; /* keep gcc quiet */ > > *cs++ = MI_LOAD_REGISTER_IMM(num_engines); > for_each_engine(signaller, engine->gt, id) { >-- >2.30.2 >
On Mon, 21 Mar 2022, Lucas De Marchi <lucas.demarchi@intel.com> wrote: > On Mon, Mar 21, 2022 at 03:59:55PM +0200, Jani Nikula wrote: >>The initialization is there only to silence the compiler, but use the >>correct initializer for i915_reg_t. >> >>Cc: Lucas De Marchi <lucas.demarchi@intel.com> >>Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Thanks, pushed a while back. BR, Jani. > > Lucas De Marchi > >>--- >> drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c >>index 6d7ec3bf1f32..5423bfd301ad 100644 >>--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c >>+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c >>@@ -767,7 +767,7 @@ static int mi_set_context(struct i915_request *rq, >> if (GRAPHICS_VER(i915) == 7) { >> if (num_engines) { >> struct intel_engine_cs *signaller; >>- i915_reg_t last_reg = {}; /* keep gcc quiet */ >>+ i915_reg_t last_reg = INVALID_MMIO_REG; /* keep gcc quiet */ >> >> *cs++ = MI_LOAD_REGISTER_IMM(num_engines); >> for_each_engine(signaller, engine->gt, id) { >>-- >>2.30.2 >>
diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c index 6d7ec3bf1f32..5423bfd301ad 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c @@ -767,7 +767,7 @@ static int mi_set_context(struct i915_request *rq, if (GRAPHICS_VER(i915) == 7) { if (num_engines) { struct intel_engine_cs *signaller; - i915_reg_t last_reg = {}; /* keep gcc quiet */ + i915_reg_t last_reg = INVALID_MMIO_REG; /* keep gcc quiet */ *cs++ = MI_LOAD_REGISTER_IMM(num_engines); for_each_engine(signaller, engine->gt, id) {
The initialization is there only to silence the compiler, but use the correct initializer for i915_reg_t. Cc: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)