| Message ID | 20221028224022.964997-1-matthew.d.roper@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/mtl: Add missing steering table terminators | expand |
On Fri, Oct 28, 2022 at 03:40:22PM -0700, Matt Roper wrote: >The termination entries were missing for a couple of the recently-added >MTL steering tables. > >Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering") >Fixes: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT") I was thinking if we would need separate commits so they can be backported independently, but no... those commits were very close. >Signed-off-by: Matt Roper <matthew.d.roper@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Lucas De Marchi >--- > drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c >index 46cf2f3d1e8e..830edffe88cc 100644 >--- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c >+++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c >@@ -128,11 +128,13 @@ static const struct intel_mmio_range xelpg_dss_steering_table[] = { > { 0x00D800, 0x00D87F }, /* SLICE */ > { 0x00DC00, 0x00DCFF }, /* SLICE */ > { 0x00DE80, 0x00E8FF }, /* DSS (0xE000-0xE0FF reserved) */ >+ {}, > }; > > static const struct intel_mmio_range xelpmp_oaddrm_steering_table[] = { > { 0x393200, 0x39323F }, > { 0x393400, 0x3934FF }, >+ {}, > }; > > void intel_gt_mcr_init(struct intel_gt *gt) >-- >2.37.3 >
On Fri, Oct 28, 2022 at 04:04:18PM -0700, Lucas De Marchi wrote: > On Fri, Oct 28, 2022 at 03:40:22PM -0700, Matt Roper wrote: > > The termination entries were missing for a couple of the recently-added > > MTL steering tables. > > > > Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering") > > Fixes: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT") > > I was thinking if we would need separate commits so they can be > backported independently, but no... those commits were very close. > > > Signed-off-by: Matt Roper <matthew.d.roper@intel.com> > > > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Thanks for the review. Applied to drm-intel-gt-next. Matt > > Lucas De Marchi > > > --- > > drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > index 46cf2f3d1e8e..830edffe88cc 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > @@ -128,11 +128,13 @@ static const struct intel_mmio_range xelpg_dss_steering_table[] = { > > { 0x00D800, 0x00D87F }, /* SLICE */ > > { 0x00DC00, 0x00DCFF }, /* SLICE */ > > { 0x00DE80, 0x00E8FF }, /* DSS (0xE000-0xE0FF reserved) */ > > + {}, > > }; > > > > static const struct intel_mmio_range xelpmp_oaddrm_steering_table[] = { > > { 0x393200, 0x39323F }, > > { 0x393400, 0x3934FF }, > > + {}, > > }; > > > > void intel_gt_mcr_init(struct intel_gt *gt) > > -- > > 2.37.3 > >
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c index 46cf2f3d1e8e..830edffe88cc 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c @@ -128,11 +128,13 @@ static const struct intel_mmio_range xelpg_dss_steering_table[] = { { 0x00D800, 0x00D87F }, /* SLICE */ { 0x00DC00, 0x00DCFF }, /* SLICE */ { 0x00DE80, 0x00E8FF }, /* DSS (0xE000-0xE0FF reserved) */ + {}, }; static const struct intel_mmio_range xelpmp_oaddrm_steering_table[] = { { 0x393200, 0x39323F }, { 0x393400, 0x3934FF }, + {}, }; void intel_gt_mcr_init(struct intel_gt *gt)
The termination entries were missing for a couple of the recently-added MTL steering tables. Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering") Fixes: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT") Signed-off-by: Matt Roper <matthew.d.roper@intel.com> --- drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 ++ 1 file changed, 2 insertions(+)