diff mbox series

[1/7] drm/i915: Remove bogus DDI-F from hsw/bdw output init

Message ID 20230511165534.10266-2-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Init DDI ports based on port_mask | expand

Commit Message

Ville Syrjälä May 11, 2023, 4:55 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

HSW/BDW don't have DDI-F so don't go looking for one.

Seems to have been accidentally left behind when the
skl+ stuff got split out in commit 097d9e902068
("drm/i915/display: remove strap checks from gen 9").

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Lucas De Marchi May 24, 2023, 3:33 p.m. UTC | #1 
On Thu, May 11, 2023 at 07:55:28PM +0300, Ville Syrjälä wrote:
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>HSW/BDW don't have DDI-F so don't go looking for one.
>
>Seems to have been accidentally left behind when the
>skl+ stuff got split out in commit 097d9e902068
>("drm/i915/display: remove strap checks from gen 9").
>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/i915/display/intel_display.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>index 1d5d42a40803..c1e0d439db79 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.c
>+++ b/drivers/gpu/drm/i915/display/intel_display.c
>@@ -7429,8 +7429,6 @@ void intel_setup_outputs(struct drm_i915_private *dev_priv)
> 			intel_ddi_init(dev_priv, PORT_C);
> 		if (found & SFUSE_STRAP_DDID_DETECTED)
> 			intel_ddi_init(dev_priv, PORT_D);
>-		if (found & SFUSE_STRAP_DDIF_DETECTED)
>-			intel_ddi_init(dev_priv, PORT_F);
> 	} else if (HAS_PCH_SPLIT(dev_priv)) {
> 		int found;
>
>-- 
>2.39.3
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 1d5d42a40803..c1e0d439db79 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7429,8 +7429,6 @@  void intel_setup_outputs(struct drm_i915_private *dev_priv)
 			intel_ddi_init(dev_priv, PORT_C);
 		if (found & SFUSE_STRAP_DDID_DETECTED)
 			intel_ddi_init(dev_priv, PORT_D);
-		if (found & SFUSE_STRAP_DDIF_DETECTED)
-			intel_ddi_init(dev_priv, PORT_F);
 	} else if (HAS_PCH_SPLIT(dev_priv)) {
 		int found;