| Message ID | 20231208143137.2402239-1-lucas.demarchi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/i915/display: Also print raw step number | expand |
On Fri, Dec 08, 2023 at 06:31:36AM -0800, Lucas De Marchi wrote: > GMD_ID is already parsed down to the step. Don't omit that information > in the display engine debug info. This helps to double check the > stepping is parsed correctly. > > For earlier platforms, it will start printing the entire version too > (which should be 0), as a rel == 0 doesn't mean it doesn't have GMD_ID. > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_device.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c > index 0b522c6a8d6f..5d1084a98b93 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_device.c > +++ b/drivers/gpu/drm/i915/display/intel_display_device.c > @@ -1122,13 +1122,8 @@ void intel_display_device_info_print(const struct intel_display_device_info *inf > const struct intel_display_runtime_info *runtime, > struct drm_printer *p) > { > - if (runtime->ip.rel) > - drm_printf(p, "display version: %u.%02u\n", > - runtime->ip.ver, > - runtime->ip.rel); > - else > - drm_printf(p, "display version: %u\n", > - runtime->ip.ver); > + drm_printf(p, "display version: %u.%02u.%02u\n", > + runtime->ip.ver, runtime->ip.rel, runtime->ip.step); > > #define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->name)) > DEV_INFO_DISPLAY_FOR_EACH_FLAG(PRINT_FLAG); > -- > 2.40.1 >
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c index 0b522c6a8d6f..5d1084a98b93 100644 --- a/drivers/gpu/drm/i915/display/intel_display_device.c +++ b/drivers/gpu/drm/i915/display/intel_display_device.c @@ -1122,13 +1122,8 @@ void intel_display_device_info_print(const struct intel_display_device_info *inf const struct intel_display_runtime_info *runtime, struct drm_printer *p) { - if (runtime->ip.rel) - drm_printf(p, "display version: %u.%02u\n", - runtime->ip.ver, - runtime->ip.rel); - else - drm_printf(p, "display version: %u\n", - runtime->ip.ver); + drm_printf(p, "display version: %u.%02u.%02u\n", + runtime->ip.ver, runtime->ip.rel, runtime->ip.step); #define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->name)) DEV_INFO_DISPLAY_FOR_EACH_FLAG(PRINT_FLAG);
GMD_ID is already parsed down to the step. Don't omit that information in the display engine debug info. This helps to double check the stepping is parsed correctly. For earlier platforms, it will start printing the entire version too (which should be 0), as a rel == 0 doesn't mean it doesn't have GMD_ID. Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/display/intel_display_device.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)