| Message ID | 20240306104513.2129442-7-jouni.hogander@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALPM AUX-Less | expand |
> -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Wednesday, March 6, 2024 4:15 PM > To: intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>; Manna, Animesh > <animesh.manna@intel.com>; Murthy, Arun R <arun.r.murthy@intel.com>; > Hogander, Jouni <jouni.hogander@intel.com> > Subject: [PATCH v3 6/6] drm/i915/psr: Do not write ALPM configuration for > PSR1 or DP2.0 Panel Replay > > No need to write ALPM configuration for DP2.0 Panel Replay or PSR1. > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > --- > drivers/gpu/drm/i915/display/intel_psr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > b/drivers/gpu/drm/i915/display/intel_psr.c > index 4cd2bad5241f..c7bda37444f0 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -1699,7 +1699,8 @@ static void lnl_alpm_configure(struct intel_dp > *intel_dp) > struct intel_psr *psr = &intel_dp->psr; > u32 alpm_ctl; > > - if (DISPLAY_VER(dev_priv) < 20) > + if (DISPLAY_VER(dev_priv) < 20 || (!intel_dp->psr.psr2_enabled && > + !intel_dp_is_edp(intel_dp))) This patch maybe good to squash with previous patch, not sure will there be any negative impact if panel does not support aux-less alpm and from source side it is enabled. Regards, Animesh > return; > > if (intel_dp->psr.panel_replay_enabled && > intel_dp_is_edp(intel_dp)) { > -- > 2.34.1
On Wed, 2024-03-13 at 11:18 +0000, Manna, Animesh wrote: > > > > -----Original Message----- > > From: Hogander, Jouni <jouni.hogander@intel.com> > > Sent: Wednesday, March 6, 2024 4:15 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>; Manna, Animesh > > <animesh.manna@intel.com>; Murthy, Arun R > > <arun.r.murthy@intel.com>; > > Hogander, Jouni <jouni.hogander@intel.com> > > Subject: [PATCH v3 6/6] drm/i915/psr: Do not write ALPM > > configuration for > > PSR1 or DP2.0 Panel Replay > > > > No need to write ALPM configuration for DP2.0 Panel Replay or PSR1. > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_psr.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > > b/drivers/gpu/drm/i915/display/intel_psr.c > > index 4cd2bad5241f..c7bda37444f0 100644 > > --- a/drivers/gpu/drm/i915/display/intel_psr.c > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > > @@ -1699,7 +1699,8 @@ static void lnl_alpm_configure(struct > > intel_dp > > *intel_dp) > > struct intel_psr *psr = &intel_dp->psr; > > u32 alpm_ctl; > > > > - if (DISPLAY_VER(dev_priv) < 20) > > + if (DISPLAY_VER(dev_priv) < 20 || (!intel_dp- > > >psr.psr2_enabled && > > + > > !intel_dp_is_edp(intel_dp))) > > This patch maybe good to squash with previous patch, not sure will > there be any negative impact if panel does not support aux-less alpm > and from source side it is enabled. These are logically different things. Previous patch is enabling ALPM for eDP panel replay. This patch could be applied already now and that would do the right thing. I.e. do not configure alpm for psr1 or panel replay. BR, Jouni Högander > > Regards, > Animesh > > > return; > > > > if (intel_dp->psr.panel_replay_enabled && > > intel_dp_is_edp(intel_dp)) { > > -- > > 2.34.1 >
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 4cd2bad5241f..c7bda37444f0 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -1699,7 +1699,8 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp) struct intel_psr *psr = &intel_dp->psr; u32 alpm_ctl; - if (DISPLAY_VER(dev_priv) < 20) + if (DISPLAY_VER(dev_priv) < 20 || (!intel_dp->psr.psr2_enabled && + !intel_dp_is_edp(intel_dp))) return; if (intel_dp->psr.panel_replay_enabled && intel_dp_is_edp(intel_dp)) {
No need to write ALPM configuration for DP2.0 Panel Replay or PSR1. Signed-off-by: Jouni Högander <jouni.hogander@intel.com> --- drivers/gpu/drm/i915/display/intel_psr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)