| Message ID | 6831c21567e8e84da424f32a8b7b48932803ab7b.1685119007.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: re-enable -Wunused-but-set-variable | expand |
Hi Jani, On Fri, May 26, 2023 at 07:38:02PM +0300, Jani Nikula wrote: > Prepare for re-enabling -Wunused-but-set-variable. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index 5fb459ea4294..cfd7929587d8 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -736,7 +736,6 @@ static int eb_reserve(struct i915_execbuffer *eb) > struct eb_vma *ev; > unsigned int pass; > int err = 0; > - bool unpinned; > > /* > * We have one more buffers that we couldn't bind, which could be due to > @@ -776,7 +775,7 @@ static int eb_reserve(struct i915_execbuffer *eb) > pin_flags |= PIN_NONBLOCK; > > if (pass >= 1) > - unpinned = eb_unbind(eb, pass >= 2); > + eb_unbind(eb, pass >= 2); Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> A next patch can make eb_unbind() a void function. Andi > > if (pass == 2) { > err = mutex_lock_interruptible(&eb->context->vm->mutex); > -- > 2.39.2
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 5fb459ea4294..cfd7929587d8 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -736,7 +736,6 @@ static int eb_reserve(struct i915_execbuffer *eb) struct eb_vma *ev; unsigned int pass; int err = 0; - bool unpinned; /* * We have one more buffers that we couldn't bind, which could be due to @@ -776,7 +775,7 @@ static int eb_reserve(struct i915_execbuffer *eb) pin_flags |= PIN_NONBLOCK; if (pass >= 1) - unpinned = eb_unbind(eb, pass >= 2); + eb_unbind(eb, pass >= 2); if (pass == 2) { err = mutex_lock_interruptible(&eb->context->vm->mutex);
Prepare for re-enabling -Wunused-but-set-variable. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)