| Message ID | e22ab28836ee1689ea4781ed53fd2e4e4f84728e.1709749576.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: fix headers, add header test facility | expand |
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240306] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-crtc-make-drm_crtc_internal-h-self-contained/20240307-023603 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/e22ab28836ee1689ea4781ed53fd2e4e4f84728e.1709749576.git.jani.nikula%40intel.com patch subject: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240307/202403071204.gJtMneoq-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403071204.gJtMneoq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202403071204.gJtMneoq-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from <command-line>: drivers/gpu/drm/./drm_crtc_internal.h: In function 'drm_edid_load_firmware': >> drivers/gpu/drm/./drm_crtc_internal.h:304:16: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration] 304 | return ERR_PTR(-ENOENT); | ^~~~~~~ >> drivers/gpu/drm/./drm_crtc_internal.h:304:25: error: 'ENOENT' undeclared (first use in this function) 304 | return ERR_PTR(-ENOENT); | ^~~~~~ drivers/gpu/drm/./drm_crtc_internal.h:304:25: note: each undeclared identifier is reported only once for each function it appears in In file included from <command-line>: drivers/gpu/drm/./drm_crtc_internal.h: At top level: >> drivers/gpu/drm/./drm_crtc_internal.h:302:1: error: redefinition of 'drm_edid_load_firmware' 302 | drm_edid_load_firmware(struct drm_connector *connector) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/./drm_crtc_internal.h:302:1: note: previous definition of 'drm_edid_load_firmware' with type 'const struct drm_edid *(struct drm_connector *)' 302 | drm_edid_load_firmware(struct drm_connector *connector) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/./drm_crtc_internal.h: In function 'drm_edid_load_firmware': >> drivers/gpu/drm/./drm_crtc_internal.h:304:25: error: 'ENOENT' undeclared (first use in this function) 304 | return ERR_PTR(-ENOENT); | ^~~~~~ cc1: all warnings being treated as errors vim +/ERR_PTR +304 drivers/gpu/drm/./drm_crtc_internal.h 5f2d0ed49036a0 Jani Nikula 2022-10-24 296 5f2d0ed49036a0 Jani Nikula 2022-10-24 297 /* drm_edid_load.c */ 5f2d0ed49036a0 Jani Nikula 2022-10-24 298 #ifdef CONFIG_DRM_LOAD_EDID_FIRMWARE 5f2d0ed49036a0 Jani Nikula 2022-10-24 299 const struct drm_edid *drm_edid_load_firmware(struct drm_connector *connector); 5f2d0ed49036a0 Jani Nikula 2022-10-24 300 #else 5f2d0ed49036a0 Jani Nikula 2022-10-24 301 static inline const struct drm_edid * 5f2d0ed49036a0 Jani Nikula 2022-10-24 @302 drm_edid_load_firmware(struct drm_connector *connector) 5f2d0ed49036a0 Jani Nikula 2022-10-24 303 { 5f2d0ed49036a0 Jani Nikula 2022-10-24 @304 return ERR_PTR(-ENOENT);
Hi Jani,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-misc/drm-misc-next]
[cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240306]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-crtc-make-drm_crtc_internal-h-self-contained/20240307-023603
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/e22ab28836ee1689ea4781ed53fd2e4e4f84728e.1709749576.git.jani.nikula%40intel.com
patch subject: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240307/202403071317.uoW18ZR3-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403071317.uoW18ZR3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403071317.uoW18ZR3-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from include/asm-generic/pgtable-nopud.h:7,
from arch/m68k/include/asm/pgtable_mm.h:9,
from arch/m68k/include/asm/pgtable.h:8,
from include/linux/pgtable.h:6,
from include/drm/ttm/ttm_caching.h:28,
from <command-line>:
>> include/asm-generic/pgtable-nop4d.h:9:18: error: unknown type name 'pgd_t'
9 | typedef struct { pgd_t pgd; } p4d_t;
| ^~~~~
include/asm-generic/pgtable-nop4d.h:21:28: error: unknown type name 'pgd_t'; did you mean 'p4d_t'?
21 | static inline int pgd_none(pgd_t pgd) { return 0; }
| ^~~~~
| p4d_t
include/asm-generic/pgtable-nop4d.h:22:27: error: unknown type name 'pgd_t'; did you mean 'p4d_t'?
22 | static inline int pgd_bad(pgd_t pgd) { return 0; }
| ^~~~~
| p4d_t
include/asm-generic/pgtable-nop4d.h:23:31: error: unknown type name 'pgd_t'; did you mean 'p4d_t'?
23 | static inline int pgd_present(pgd_t pgd) { return 1; }
| ^~~~~
| p4d_t
include/asm-generic/pgtable-nop4d.h:24:30: error: unknown type name 'pgd_t'; did you mean 'p4d_t'?
24 | static inline void pgd_clear(pgd_t *pgd) { }
| ^~~~~
| p4d_t
include/asm-generic/pgtable-nop4d.h:35:33: error: unknown type name 'pgd_t'; did you mean 'p4d_t'?
35 | static inline p4d_t *p4d_offset(pgd_t *pgd, unsigned long address)
| ^~~~~
| p4d_t
In file included from arch/m68k/include/asm/thread_info.h:6,
from include/linux/thread_info.h:60,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from arch/m68k/include/asm/processor.h:11,
from arch/m68k/include/asm/pgtable_mm.h:15:
arch/m68k/include/asm/motorola_pgtable.h: In function 'pud_set':
>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union
46 | #define pgd_val(x) ((x).pgd)
| ^
include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val'
40 | #define p4d_val(x) (pgd_val((x).pgd))
| ^~~~~~~
include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val'
48 | #define pud_val(x) (p4d_val((x).p4d))
| ^~~~~~~
arch/m68k/include/asm/motorola_pgtable.h:103:9: note: in expansion of macro 'pud_val'
103 | pud_val(*pudp) = _PAGE_TABLE | _PAGE_ACCESSED | __pa(pmdp);
| ^~~~~~~
include/linux/pgtable.h: In function 'pmd_offset':
>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union
46 | #define pgd_val(x) ((x).pgd)
| ^
include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val'
40 | #define p4d_val(x) (pgd_val((x).pgd))
| ^~~~~~~
include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val'
48 | #define pud_val(x) (p4d_val((x).p4d))
| ^~~~~~~
arch/m68k/include/asm/motorola_pgtable.h:108:41: note: in expansion of macro 'pud_val'
108 | #define pud_pgtable(pud) ((pmd_t *)__va(pud_val(pud) & _TABLE_MASK))
| ^~~~~~~
include/linux/pgtable.h:123:16: note: in expansion of macro 'pud_pgtable'
123 | return pud_pgtable(*pud) + pmd_index(address);
| ^~~~~~~~~~~
include/linux/pgtable.h: In function 'pmd_off':
>> include/linux/pgtable.h:165:38: error: implicit declaration of function 'p4d_offset'; did you mean 'pmd_offset'? [-Werror=implicit-function-declaration]
165 | return pmd_offset(pud_offset(p4d_offset(pgd_offset(mm, va), va), va), va);
| ^~~~~~~~~~
| pmd_offset
>> include/linux/pgtable.h:165:38: warning: passing argument 1 of 'pud_offset' makes pointer from integer without a cast [-Wint-conversion]
165 | return pmd_offset(pud_offset(p4d_offset(pgd_offset(mm, va), va), va), va);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
include/asm-generic/pgtable-nopud.h:42:40: note: expected 'p4d_t *' but argument is of type 'int'
42 | static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address)
| ~~~~~~~^~~
include/linux/pgtable.h: In function 'pmd_off_k':
include/linux/pgtable.h:170:38: warning: passing argument 1 of 'pud_offset' makes pointer from integer without a cast [-Wint-conversion]
170 | return pmd_offset(pud_offset(p4d_offset(pgd_offset_k(va), va), va), va);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
include/asm-generic/pgtable-nopud.h:42:40: note: expected 'p4d_t *' but argument is of type 'int'
42 | static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address)
| ~~~~~~~^~~
include/linux/pgtable.h: In function 'pud_same':
>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union
46 | #define pgd_val(x) ((x).pgd)
| ^
include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val'
40 | #define p4d_val(x) (pgd_val((x).pgd))
| ^~~~~~~
include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val'
48 | #define pud_val(x) (p4d_val((x).p4d))
| ^~~~~~~
include/linux/pgtable.h:829:16: note: in expansion of macro 'pud_val'
829 | return pud_val(pud_a) == pud_val(pud_b);
| ^~~~~~~
>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union
46 | #define pgd_val(x) ((x).pgd)
| ^
include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val'
40 | #define p4d_val(x) (pgd_val((x).pgd))
| ^~~~~~~
include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val'
48 | #define pud_val(x) (p4d_val((x).p4d))
| ^~~~~~~
include/linux/pgtable.h:829:34: note: in expansion of macro 'pud_val'
829 | return pud_val(pud_a) == pud_val(pud_b);
| ^~~~~~~
>> include/linux/pgtable.h:827:34: warning: parameter 'pud_a' set but not used [-Wunused-but-set-parameter]
827 | static inline int pud_same(pud_t pud_a, pud_t pud_b)
| ~~~~~~^~~~~
>> include/linux/pgtable.h:827:47: warning: parameter 'pud_b' set but not used [-Wunused-but-set-parameter]
827 | static inline int pud_same(pud_t pud_a, pud_t pud_b)
| ~~~~~~^~~~~
include/linux/pgtable.h: In function 'p4d_same':
>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union
46 | #define pgd_val(x) ((x).pgd)
| ^
include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val'
40 | #define p4d_val(x) (pgd_val((x).pgd))
| ^~~~~~~
include/linux/pgtable.h:837:16: note: in expansion of macro 'p4d_val'
837 | return p4d_val(p4d_a) == p4d_val(p4d_b);
| ^~~~~~~
>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union
46 | #define pgd_val(x) ((x).pgd)
| ^
include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val'
40 | #define p4d_val(x) (pgd_val((x).pgd))
| ^~~~~~~
include/linux/pgtable.h:837:34: note: in expansion of macro 'p4d_val'
837 | return p4d_val(p4d_a) == p4d_val(p4d_b);
| ^~~~~~~
>> include/linux/pgtable.h:835:34: warning: parameter 'p4d_a' set but not used [-Wunused-but-set-parameter]
835 | static inline int p4d_same(p4d_t p4d_a, p4d_t p4d_b)
| ~~~~~~^~~~~
>> include/linux/pgtable.h:835:47: warning: parameter 'p4d_b' set but not used [-Wunused-but-set-parameter]
835 | static inline int p4d_same(p4d_t p4d_a, p4d_t p4d_b)
| ~~~~~~^~~~~
include/linux/pgtable.h: In function 'pgd_none_or_clear_bad':
>> include/linux/pgtable.h:1021:13: error: implicit declaration of function 'pgd_none'; did you mean 'p4d_none'? [-Werror=implicit-function-declaration]
1021 | if (pgd_none(*pgd))
| ^~~~~~~~
| p4d_none
In file included from include/linux/export.h:5,
from include/linux/linkage.h:7,
from include/linux/preempt.h:10:
>> include/linux/pgtable.h:1023:22: error: implicit declaration of function 'pgd_bad'; did you mean 'p4d_bad'? [-Werror=implicit-function-declaration]
1023 | if (unlikely(pgd_bad(*pgd))) {
| ^~~~~~~
include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/pgtable.h: In function 'pud_none_or_clear_bad':
>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union
46 | #define pgd_val(x) ((x).pgd)
| ^
include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val'
40 | #define p4d_val(x) (pgd_val((x).pgd))
| ^~~~~~~
include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val'
48 | #define pud_val(x) (p4d_val((x).p4d))
| ^~~~~~~
arch/m68k/include/asm/motorola_pgtable.h:134:35: note: in expansion of macro 'pud_val'
134 | #define pud_none(pud) (!pud_val(pud))
| ^~~~~~~
include/linux/pgtable.h:1043:13: note: in expansion of macro 'pud_none'
1043 | if (pud_none(*pud))
| ^~~~~~~~
>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union
46 | #define pgd_val(x) ((x).pgd)
| ^
include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val'
40 | #define p4d_val(x) (pgd_val((x).pgd))
| ^~~~~~~
include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val'
48 | #define pud_val(x) (p4d_val((x).p4d))
| ^~~~~~~
arch/m68k/include/asm/motorola_pgtable.h:135:35: note: in expansion of macro 'pud_val'
135 | #define pud_bad(pud) ((pud_val(pud) & _DESCTYPE_MASK) != _PAGE_TABLE)
| ^~~~~~~
include/linux/pgtable.h:1045:22: note: in expansion of macro 'pud_bad'
1045 | if (unlikely(pud_bad(*pud))) {
| ^~~~~~~
cc1: some warnings being treated as errors
vim +/pgd_t +9 include/asm-generic/pgtable-nop4d.h
048456dcf2c56a Kirill A. Shutemov 2017-03-09 8
048456dcf2c56a Kirill A. Shutemov 2017-03-09 @9 typedef struct { pgd_t pgd; } p4d_t;
048456dcf2c56a Kirill A. Shutemov 2017-03-09 10
On Thu, 07 Mar 2024, kernel test robot <lkp@intel.com> wrote: > Hi Jani, > > kernel test robot noticed the following build errors: So I'm trying to make include/drm/ttm/ttm_caching.h self-contained by including <linux/pgtable.h> with [1], but it fails like below. Cc: Thomas and Geert, better ideas for the include there? Looks like include/asm-generic/pgtable-nop4d.h isn't self-contained on m68k. BR, Jani. [1] https://lore.kernel.org/r/c35ce1a59d0796da32b32e4c8f59464de35f200a.1709749576.git.jani.nikula@intel.com > > [auto build test ERROR on drm-misc/drm-misc-next] > [cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240306] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-crtc-make-drm_crtc_internal-h-self-contained/20240307-023603 > base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > patch link: https://lore.kernel.org/r/e22ab28836ee1689ea4781ed53fd2e4e4f84728e.1709749576.git.jani.nikula%40intel.com > patch subject: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc > config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240307/202403071317.uoW18ZR3-lkp@intel.com/config) > compiler: m68k-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403071317.uoW18ZR3-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202403071317.uoW18ZR3-lkp@intel.com/ > > All error/warnings (new ones prefixed by >>): > > In file included from include/asm-generic/pgtable-nopud.h:7, > from arch/m68k/include/asm/pgtable_mm.h:9, > from arch/m68k/include/asm/pgtable.h:8, > from include/linux/pgtable.h:6, > from include/drm/ttm/ttm_caching.h:28, > from <command-line>: >>> include/asm-generic/pgtable-nop4d.h:9:18: error: unknown type name 'pgd_t' > 9 | typedef struct { pgd_t pgd; } p4d_t; > | ^~~~~ > include/asm-generic/pgtable-nop4d.h:21:28: error: unknown type name 'pgd_t'; did you mean 'p4d_t'? > 21 | static inline int pgd_none(pgd_t pgd) { return 0; } > | ^~~~~ > | p4d_t > include/asm-generic/pgtable-nop4d.h:22:27: error: unknown type name 'pgd_t'; did you mean 'p4d_t'? > 22 | static inline int pgd_bad(pgd_t pgd) { return 0; } > | ^~~~~ > | p4d_t > include/asm-generic/pgtable-nop4d.h:23:31: error: unknown type name 'pgd_t'; did you mean 'p4d_t'? > 23 | static inline int pgd_present(pgd_t pgd) { return 1; } > | ^~~~~ > | p4d_t > include/asm-generic/pgtable-nop4d.h:24:30: error: unknown type name 'pgd_t'; did you mean 'p4d_t'? > 24 | static inline void pgd_clear(pgd_t *pgd) { } > | ^~~~~ > | p4d_t > include/asm-generic/pgtable-nop4d.h:35:33: error: unknown type name 'pgd_t'; did you mean 'p4d_t'? > 35 | static inline p4d_t *p4d_offset(pgd_t *pgd, unsigned long address) > | ^~~~~ > | p4d_t > In file included from arch/m68k/include/asm/thread_info.h:6, > from include/linux/thread_info.h:60, > from include/asm-generic/preempt.h:5, > from ./arch/m68k/include/generated/asm/preempt.h:1, > from include/linux/preempt.h:79, > from arch/m68k/include/asm/processor.h:11, > from arch/m68k/include/asm/pgtable_mm.h:15: > arch/m68k/include/asm/motorola_pgtable.h: In function 'pud_set': >>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union > 46 | #define pgd_val(x) ((x).pgd) > | ^ > include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val' > 40 | #define p4d_val(x) (pgd_val((x).pgd)) > | ^~~~~~~ > include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val' > 48 | #define pud_val(x) (p4d_val((x).p4d)) > | ^~~~~~~ > arch/m68k/include/asm/motorola_pgtable.h:103:9: note: in expansion of macro 'pud_val' > 103 | pud_val(*pudp) = _PAGE_TABLE | _PAGE_ACCESSED | __pa(pmdp); > | ^~~~~~~ > include/linux/pgtable.h: In function 'pmd_offset': >>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union > 46 | #define pgd_val(x) ((x).pgd) > | ^ > include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val' > 40 | #define p4d_val(x) (pgd_val((x).pgd)) > | ^~~~~~~ > include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val' > 48 | #define pud_val(x) (p4d_val((x).p4d)) > | ^~~~~~~ > arch/m68k/include/asm/motorola_pgtable.h:108:41: note: in expansion of macro 'pud_val' > 108 | #define pud_pgtable(pud) ((pmd_t *)__va(pud_val(pud) & _TABLE_MASK)) > | ^~~~~~~ > include/linux/pgtable.h:123:16: note: in expansion of macro 'pud_pgtable' > 123 | return pud_pgtable(*pud) + pmd_index(address); > | ^~~~~~~~~~~ > include/linux/pgtable.h: In function 'pmd_off': >>> include/linux/pgtable.h:165:38: error: implicit declaration of function 'p4d_offset'; did you mean 'pmd_offset'? [-Werror=implicit-function-declaration] > 165 | return pmd_offset(pud_offset(p4d_offset(pgd_offset(mm, va), va), va), va); > | ^~~~~~~~~~ > | pmd_offset >>> include/linux/pgtable.h:165:38: warning: passing argument 1 of 'pud_offset' makes pointer from integer without a cast [-Wint-conversion] > 165 | return pmd_offset(pud_offset(p4d_offset(pgd_offset(mm, va), va), va), va); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | > | int > include/asm-generic/pgtable-nopud.h:42:40: note: expected 'p4d_t *' but argument is of type 'int' > 42 | static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address) > | ~~~~~~~^~~ > include/linux/pgtable.h: In function 'pmd_off_k': > include/linux/pgtable.h:170:38: warning: passing argument 1 of 'pud_offset' makes pointer from integer without a cast [-Wint-conversion] > 170 | return pmd_offset(pud_offset(p4d_offset(pgd_offset_k(va), va), va), va); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | > | int > include/asm-generic/pgtable-nopud.h:42:40: note: expected 'p4d_t *' but argument is of type 'int' > 42 | static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address) > | ~~~~~~~^~~ > include/linux/pgtable.h: In function 'pud_same': >>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union > 46 | #define pgd_val(x) ((x).pgd) > | ^ > include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val' > 40 | #define p4d_val(x) (pgd_val((x).pgd)) > | ^~~~~~~ > include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val' > 48 | #define pud_val(x) (p4d_val((x).p4d)) > | ^~~~~~~ > include/linux/pgtable.h:829:16: note: in expansion of macro 'pud_val' > 829 | return pud_val(pud_a) == pud_val(pud_b); > | ^~~~~~~ >>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union > 46 | #define pgd_val(x) ((x).pgd) > | ^ > include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val' > 40 | #define p4d_val(x) (pgd_val((x).pgd)) > | ^~~~~~~ > include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val' > 48 | #define pud_val(x) (p4d_val((x).p4d)) > | ^~~~~~~ > include/linux/pgtable.h:829:34: note: in expansion of macro 'pud_val' > 829 | return pud_val(pud_a) == pud_val(pud_b); > | ^~~~~~~ >>> include/linux/pgtable.h:827:34: warning: parameter 'pud_a' set but not used [-Wunused-but-set-parameter] > 827 | static inline int pud_same(pud_t pud_a, pud_t pud_b) > | ~~~~~~^~~~~ >>> include/linux/pgtable.h:827:47: warning: parameter 'pud_b' set but not used [-Wunused-but-set-parameter] > 827 | static inline int pud_same(pud_t pud_a, pud_t pud_b) > | ~~~~~~^~~~~ > include/linux/pgtable.h: In function 'p4d_same': >>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union > 46 | #define pgd_val(x) ((x).pgd) > | ^ > include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val' > 40 | #define p4d_val(x) (pgd_val((x).pgd)) > | ^~~~~~~ > include/linux/pgtable.h:837:16: note: in expansion of macro 'p4d_val' > 837 | return p4d_val(p4d_a) == p4d_val(p4d_b); > | ^~~~~~~ >>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union > 46 | #define pgd_val(x) ((x).pgd) > | ^ > include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val' > 40 | #define p4d_val(x) (pgd_val((x).pgd)) > | ^~~~~~~ > include/linux/pgtable.h:837:34: note: in expansion of macro 'p4d_val' > 837 | return p4d_val(p4d_a) == p4d_val(p4d_b); > | ^~~~~~~ >>> include/linux/pgtable.h:835:34: warning: parameter 'p4d_a' set but not used [-Wunused-but-set-parameter] > 835 | static inline int p4d_same(p4d_t p4d_a, p4d_t p4d_b) > | ~~~~~~^~~~~ >>> include/linux/pgtable.h:835:47: warning: parameter 'p4d_b' set but not used [-Wunused-but-set-parameter] > 835 | static inline int p4d_same(p4d_t p4d_a, p4d_t p4d_b) > | ~~~~~~^~~~~ > include/linux/pgtable.h: In function 'pgd_none_or_clear_bad': >>> include/linux/pgtable.h:1021:13: error: implicit declaration of function 'pgd_none'; did you mean 'p4d_none'? [-Werror=implicit-function-declaration] > 1021 | if (pgd_none(*pgd)) > | ^~~~~~~~ > | p4d_none > In file included from include/linux/export.h:5, > from include/linux/linkage.h:7, > from include/linux/preempt.h:10: >>> include/linux/pgtable.h:1023:22: error: implicit declaration of function 'pgd_bad'; did you mean 'p4d_bad'? [-Werror=implicit-function-declaration] > 1023 | if (unlikely(pgd_bad(*pgd))) { > | ^~~~~~~ > include/linux/compiler.h:77:45: note: in definition of macro 'unlikely' > 77 | # define unlikely(x) __builtin_expect(!!(x), 0) > | ^ > include/linux/pgtable.h: In function 'pud_none_or_clear_bad': >>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union > 46 | #define pgd_val(x) ((x).pgd) > | ^ > include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val' > 40 | #define p4d_val(x) (pgd_val((x).pgd)) > | ^~~~~~~ > include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val' > 48 | #define pud_val(x) (p4d_val((x).p4d)) > | ^~~~~~~ > arch/m68k/include/asm/motorola_pgtable.h:134:35: note: in expansion of macro 'pud_val' > 134 | #define pud_none(pud) (!pud_val(pud)) > | ^~~~~~~ > include/linux/pgtable.h:1043:13: note: in expansion of macro 'pud_none' > 1043 | if (pud_none(*pud)) > | ^~~~~~~~ >>> arch/m68k/include/asm/page.h:46:29: error: request for member 'pgd' in something not a structure or union > 46 | #define pgd_val(x) ((x).pgd) > | ^ > include/linux/compiler.h:77:45: note: in definition of macro 'unlikely' > 77 | # define unlikely(x) __builtin_expect(!!(x), 0) > | ^ > include/asm-generic/pgtable-nop4d.h:40:50: note: in expansion of macro 'pgd_val' > 40 | #define p4d_val(x) (pgd_val((x).pgd)) > | ^~~~~~~ > include/asm-generic/pgtable-nopud.h:48:50: note: in expansion of macro 'p4d_val' > 48 | #define pud_val(x) (p4d_val((x).p4d)) > | ^~~~~~~ > arch/m68k/include/asm/motorola_pgtable.h:135:35: note: in expansion of macro 'pud_val' > 135 | #define pud_bad(pud) ((pud_val(pud) & _DESCTYPE_MASK) != _PAGE_TABLE) > | ^~~~~~~ > include/linux/pgtable.h:1045:22: note: in expansion of macro 'pud_bad' > 1045 | if (unlikely(pud_bad(*pud))) { > | ^~~~~~~ > cc1: some warnings being treated as errors > > > vim +/pgd_t +9 include/asm-generic/pgtable-nop4d.h > > 048456dcf2c56a Kirill A. Shutemov 2017-03-09 8 > 048456dcf2c56a Kirill A. Shutemov 2017-03-09 @9 typedef struct { pgd_t pgd; } p4d_t; > 048456dcf2c56a Kirill A. Shutemov 2017-03-09 10
Hi Jani, On Thu, Mar 7, 2024 at 9:44 AM Jani Nikula <jani.nikula@intel.com> wrote: > On Thu, 07 Mar 2024, kernel test robot <lkp@intel.com> wrote: > > kernel test robot noticed the following build errors: > > So I'm trying to make include/drm/ttm/ttm_caching.h self-contained by > including <linux/pgtable.h> with [1], but it fails like below. > > Cc: Thomas and Geert, better ideas for the include there? Looks like > include/asm-generic/pgtable-nop4d.h isn't self-contained on m68k. I have sent a fix https://lore.kernel.org/r/ba359be013f379ff10f3afcea13e2f78dd9717be.1709804021.git.geert@linux-m68k.org Gr{oetje,eeting}s, Geert
Hi Jani,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240307]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-crtc-make-drm_crtc_internal-h-self-contained/20240307-023603
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/e22ab28836ee1689ea4781ed53fd2e4e4f84728e.1709749576.git.jani.nikula%40intel.com
patch subject: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240307/202403072259.EEC2Vf1X-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 325f51237252e6dab8e4e1ea1fa7acbb4faee1cd)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403072259.EEC2Vf1X-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403072259.EEC2Vf1X-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from <built-in>:4:
>> include/drm/ttm/ttm_pool.h:89:52: warning: declaration of 'struct seq_file' will not be visible outside of this function [-Wvisibility]
89 | int ttm_pool_debugfs(struct ttm_pool *pool, struct seq_file *m);
| ^
1 warning generated.
vim +89 include/drm/ttm/ttm_pool.h
d099fc8f540add Christian König 2020-10-22 88
d099fc8f540add Christian König 2020-10-22 @89 int ttm_pool_debugfs(struct ttm_pool *pool, struct seq_file *m);
d099fc8f540add Christian König 2020-10-22 90
On Thu, 07 Mar 2024, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Jani, > > On Thu, Mar 7, 2024 at 9:44 AM Jani Nikula <jani.nikula@intel.com> wrote: >> On Thu, 07 Mar 2024, kernel test robot <lkp@intel.com> wrote: >> > kernel test robot noticed the following build errors: >> >> So I'm trying to make include/drm/ttm/ttm_caching.h self-contained by >> including <linux/pgtable.h> with [1], but it fails like below. >> >> Cc: Thomas and Geert, better ideas for the include there? Looks like >> include/asm-generic/pgtable-nop4d.h isn't self-contained on m68k. > > I have sent a fix > > https://lore.kernel.org/r/ba359be013f379ff10f3afcea13e2f78dd9717be.1709804021.git.geert@linux-m68k.org Thanks! I've picked this up as part of my series, and will include it with the other remaining patches when I post a v2, aiming to merge all of them via drm-misc-next. BR, Jani. > > Gr{oetje,eeting}s, > > Geert
diff --git a/Kbuild b/Kbuild index 464b34a08f51..f327ca86990c 100644 --- a/Kbuild +++ b/Kbuild @@ -97,3 +97,4 @@ obj-$(CONFIG_SAMPLES) += samples/ obj-$(CONFIG_NET) += net/ obj-y += virt/ obj-y += $(ARCH_DRIVERS) +obj-$(CONFIG_DRM_HEADER_TEST) += include/ diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index c08e18108c2a..dd17685ef6e7 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -429,3 +429,14 @@ config DRM_WERROR this config option is disabled by default. If in doubt, say N. + +config DRM_HEADER_TEST + bool "Ensure DRM headers are self-contained and pass kernel-doc" + depends on EXPERT + default n + help + Ensure the DRM subsystem headers both under drivers/gpu/drm and + include/drm compile, are self-contained, have header guards, and have + no kernel-doc warnings. + + If in doubt, say N. diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index a73c04d2d7a3..6605d5686d01 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -218,3 +218,21 @@ obj-y += solomon/ obj-$(CONFIG_DRM_SPRD) += sprd/ obj-$(CONFIG_DRM_LOONGSON) += loongson/ obj-$(CONFIG_DRM_POWERVR) += imagination/ + +# Ensure drm headers are self-contained and pass kernel-doc +hdrtest-files := \ + $(shell cd $(srctree)/$(src) && find . -maxdepth 1 -name 'drm_*.h') \ + $(shell cd $(srctree)/$(src) && find display lib -name '*.h') + +always-$(CONFIG_DRM_HEADER_TEST) += \ + $(patsubst %.h,%.hdrtest, $(hdrtest-files)) + +# Include the header twice to detect missing include guard. +quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@) + cmd_hdrtest = \ + $(CC) $(c_flags) -fsyntax-only -x c /dev/null -include $< -include $<; \ + $(srctree)/scripts/kernel-doc -none $(if $(CONFIG_DRM_WERROR),-Werror) $<; \ + touch $@ + +$(obj)/%.hdrtest: $(src)/%.h FORCE + $(call if_changed_dep,hdrtest) diff --git a/include/Kbuild b/include/Kbuild new file mode 100644 index 000000000000..5e76a599e2dd --- /dev/null +++ b/include/Kbuild @@ -0,0 +1 @@ +obj-$(CONFIG_DRM_HEADER_TEST) += drm/ diff --git a/include/drm/Makefile b/include/drm/Makefile new file mode 100644 index 000000000000..b9f391d7aadd --- /dev/null +++ b/include/drm/Makefile @@ -0,0 +1,18 @@ +# SPDX-License-Identifier: GPL-2.0 + +# Ensure drm headers are self-contained and pass kernel-doc +hdrtest-files := \ + $(shell cd $(srctree)/$(src) && find * -name '*.h' 2>/dev/null) + +always-$(CONFIG_DRM_HEADER_TEST) += \ + $(patsubst %.h,%.hdrtest, $(hdrtest-files)) + +# Include the header twice to detect missing include guard. +quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@) + cmd_hdrtest = \ + $(CC) $(c_flags) -fsyntax-only -x c /dev/null -include $< -include $<; \ + $(srctree)/scripts/kernel-doc -none $(if $(CONFIG_DRM_WERROR),-Werror) $<; \ + touch $@ + +$(obj)/%.hdrtest: $(src)/%.h FORCE + $(call if_changed_dep,hdrtest)
Ensure drm headers build, are self-contained, have header guards, and have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y. The mechanism follows similar patters used in i915, xe, and usr/include. To cover include/drm, we need to recurse there using the top level Kbuild and the new include/Kbuild files. Suggested-by: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- Kbuild | 1 + drivers/gpu/drm/Kconfig | 11 +++++++++++ drivers/gpu/drm/Makefile | 18 ++++++++++++++++++ include/Kbuild | 1 + include/drm/Makefile | 18 ++++++++++++++++++ 5 files changed, 49 insertions(+) create mode 100644 include/Kbuild create mode 100644 include/drm/Makefile