[0/2] kvm-unit-test: nVMX: Test "Load IA32_EFER" VM-exit control on vmentry of nested guests

Message

Krish Sadhukhan May 22, 2019, 11:45 p.m. UTC

Patch# 1 creates a wrapper for checking if the NX bit in MSR_EFER is enabled.
It is used in patch# 2.

Patch# 2 adds tests for "Load IA32_EFER" VM-exit control.


[PATCH 1/2] kvm-unit-test: x86: Add a wrapper to check if the CPU supports NX bit in
[PATCH 2/2] kvm-unit-test: nVMX: Test "Load IA32_EFER" VM-exit control on vmentry of

 lib/x86/processor.h |   8 ++++
 x86/vmexit.c        |   2 +-
 x86/vmx_tests.c     | 121 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 130 insertions(+), 1 deletion(-)

Krish Sadhukhan (2):
      x86: Add a wrapper to check if the CPU supports NX bit in MSR_EFER
      nVMX: Test "Load IA32_EFER" VM-exit control on vmentry of nested guests

Comments

Paolo Bonzini June 6, 2019, 12:48 p.m. UTC | #1

On 23/05/19 01:45, Krish Sadhukhan wrote:
> Patch# 1 creates a wrapper for checking if the NX bit in MSR_EFER is enabled.
> It is used in patch# 2.
> 
> Patch# 2 adds tests for "Load IA32_EFER" VM-exit control.

Queued with the change suggested by Sean, but this was also on top of
some patches that you have not sent yet because patch 2 didn't apply
cleanly.

Paolo


> 
> [PATCH 1/2] kvm-unit-test: x86: Add a wrapper to check if the CPU supports NX bit in
> [PATCH 2/2] kvm-unit-test: nVMX: Test "Load IA32_EFER" VM-exit control on vmentry of
> 
>  lib/x86/processor.h |   8 ++++
>  x86/vmexit.c        |   2 +-
>  x86/vmx_tests.c     | 121 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 130 insertions(+), 1 deletion(-)
> 
> Krish Sadhukhan (2):
>       x86: Add a wrapper to check if the CPU supports NX bit in MSR_EFER
>       nVMX: Test "Load IA32_EFER" VM-exit control on vmentry of nested guests
>

Krish Sadhukhan June 8, 2019, 1:17 a.m. UTC | #2

On 06/06/2019 05:48 AM, Paolo Bonzini wrote:
> On 23/05/19 01:45, Krish Sadhukhan wrote:
>> Patch# 1 creates a wrapper for checking if the NX bit in MSR_EFER is enabled.
>> It is used in patch# 2.
>>
>> Patch# 2 adds tests for "Load IA32_EFER" VM-exit control.
> Queued with the change suggested by Sean, but this was also on top of
> some patches that you have not sent yet because patch 2 didn't apply
> cleanly.

Yes, this patchset was stacked on top of the following (pending v2) 
patchset in my git repo:

         [KVM nVMX]: Check "load IA32_PERF_GLOBAL_CTRL" on vmentry of 
nested guests


But the two patchsets are not functionally dependent, so we are good.

Thanks.

> Paolo
>
>
>> [PATCH 1/2] kvm-unit-test: x86: Add a wrapper to check if the CPU supports NX bit in
>> [PATCH 2/2] kvm-unit-test: nVMX: Test "Load IA32_EFER" VM-exit control on vmentry of
>>
>>   lib/x86/processor.h |   8 ++++
>>   x86/vmexit.c        |   2 +-
>>   x86/vmx_tests.c     | 121 ++++++++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 130 insertions(+), 1 deletion(-)
>>
>> Krish Sadhukhan (2):
>>        x86: Add a wrapper to check if the CPU supports NX bit in MSR_EFER
>>        nVMX: Test "Load IA32_EFER" VM-exit control on vmentry of nested guests
>>