| Message ID | cover.1562854091.git.alifm@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Some vfio-ccw fixes | expand |
On Thu, 11 Jul 2019 10:28:50 -0400 Farhan Ali <alifm@linux.ibm.com> wrote: > Hi, > > While trying to chase down the problem regarding the stacktraces, > I have also found some minor problems in the code. > > Would appreciate any review or feedback regarding them. > > Thanks > Farhan > > ChangeLog > --------- > v2 -> v3 > - Minor changes as suggested by Conny > - Add Conny's reviewed-by tags > - Add fixes tag for patch 4 and patch 5 > > v1 -> v2 > - Update docs for csch/hsch since we can support those > instructions now (patch 5) > - Fix the memory leak where we fail to free a ccwchain (patch 2) > - Add fixes tag where appropriate. > - Fix comment instead of the order when setting orb.cmd.c64 (patch 1) > > > Farhan Ali (5): > vfio-ccw: Fix misleading comment when setting orb.cmd.c64 > vfio-ccw: Fix memory leak and don't call cp_free in cp_init > vfio-ccw: Set pa_nr to 0 if memory allocation fails for pa_iova_pfn > vfio-ccw: Don't call cp_free if we are processing a channel program > vfio-ccw: Update documentation for csch/hsch > > Documentation/s390/vfio-ccw.rst | 31 ++++++++++++++++++++++++++++--- > drivers/s390/cio/vfio_ccw_cp.c | 28 +++++++++++++++++----------- > drivers/s390/cio/vfio_ccw_drv.c | 2 +- > 3 files changed, 46 insertions(+), 15 deletions(-) > Thanks, did the fixup for patch 5 and queued to vfio-ccw-fixes.
Hi, While trying to chase down the problem regarding the stacktraces, I have also found some minor problems in the code. Would appreciate any review or feedback regarding them. Thanks Farhan ChangeLog --------- v2 -> v3 - Minor changes as suggested by Conny - Add Conny's reviewed-by tags - Add fixes tag for patch 4 and patch 5 v1 -> v2 - Update docs for csch/hsch since we can support those instructions now (patch 5) - Fix the memory leak where we fail to free a ccwchain (patch 2) - Add fixes tag where appropriate. - Fix comment instead of the order when setting orb.cmd.c64 (patch 1) Farhan Ali (5): vfio-ccw: Fix misleading comment when setting orb.cmd.c64 vfio-ccw: Fix memory leak and don't call cp_free in cp_init vfio-ccw: Set pa_nr to 0 if memory allocation fails for pa_iova_pfn vfio-ccw: Don't call cp_free if we are processing a channel program vfio-ccw: Update documentation for csch/hsch Documentation/s390/vfio-ccw.rst | 31 ++++++++++++++++++++++++++++--- drivers/s390/cio/vfio_ccw_cp.c | 28 +++++++++++++++++----------- drivers/s390/cio/vfio_ccw_drv.c | 2 +- 3 files changed, 46 insertions(+), 15 deletions(-)