Message ID | 20210713163324.627647-32-seanjc@google.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <kvm-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3118C07E96 for <kvm@archiver.kernel.org>; Tue, 13 Jul 2021 16:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C98EA6100A for <kvm@archiver.kernel.org>; Tue, 13 Jul 2021 16:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234452AbhGMQiT (ORCPT <rfc822;kvm@archiver.kernel.org>); Tue, 13 Jul 2021 12:38:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235172AbhGMQiD (ORCPT <rfc822;kvm@vger.kernel.org>); Tue, 13 Jul 2021 12:38:03 -0400 Received: from mail-qt1-x84a.google.com (mail-qt1-x84a.google.com [IPv6:2607:f8b0:4864:20::84a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA595C0617AB for <kvm@vger.kernel.org>; Tue, 13 Jul 2021 09:34:33 -0700 (PDT) Received: by mail-qt1-x84a.google.com with SMTP id 12-20020ac8570c0000b02902520e309f5dso12870069qtw.8 for <kvm@vger.kernel.org>; Tue, 13 Jul 2021 09:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=O8F2nWEtJIYygcgMXcnof9oNbtAG6cyy1DOkdSdwMwg=; b=lU/BnI4u37nMxKBf4RWQS1VmHCe7EUt2MinPqtPnyxVcBwX/6V64VvvmeOcembhiO6 Fprqn/CnOqJMKcsOPPzucpZLv1vGA1N9tcnpLtaiHfDYfqNCgC/zob/VQjdxKRpyQnof QBBb1uS5huu4/kLbkHYr/5X+FgA9vJTv8rcGXNLigLmmuXXM4AOdXbQtEfDjM6t0Z+Wy TdKLoA5l5QH6h7TTEQLkgDvNbBQ3XRmxsmjUFyEHcR/2ORuq1waGYySNCSIpAOIdlP9u 4rRsLSxw5MS4UPJR8mYRLGLusoXXR9fs5C6dgZCdKlGAAcu0EXIEORb7T9ZPFN3Pj0O0 m0Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=O8F2nWEtJIYygcgMXcnof9oNbtAG6cyy1DOkdSdwMwg=; b=YsfEVCP4X5xJJfhwFKIKzZKRWbDTreK5rrNl8qvYDBeFah3egBiga/rmuAnxXPNqnr KrLglUp+gzN9I9rRpYBrP662X/YlTAHKPJk/tls1iktDNiASVEiKtUJKgKN3HGgBEw7X w0XWC15wwHXrZr0FLxrR62Sa/0qUQTV9Vbs/DUwh7tU2tD5YB8MkoOS8NEeb0FDH0rfa Uf+xgqWf2LhnNE7IU77jNBoa+lQmVF+Kw/g09DN/tVMQMtTmtNyzz4IffptuSjo9Hp8V F34XEuKs8gPLkBZ6zs6m+Aj9BogWWXqZ9lQvSE//onZBmL1TZCyMCIe87/4iG0t6NPtf 8DrA== X-Gm-Message-State: AOAM530TmdJyPfF/LH257a/FyvygrN2k7cTh2We/ivdG+ULNaDgT2QGP RTDzoHXL29pYz4eRwxT46P8Ggji+0S0= X-Google-Smtp-Source: ABdhPJyPd/xo5zM+iDP1oWprDa1FMBnkUeM41nu9gskrU1zIA0fuH2wN+X9Rl3NkeEyMGrhXmO9eCog+ck0= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:90:200:825e:11a1:364b:8109]) (user=seanjc job=sendgmr) by 2002:a05:6214:1141:: with SMTP id b1mr5849322qvt.2.1626194073090; Tue, 13 Jul 2021 09:34:33 -0700 (PDT) Reply-To: Sean Christopherson <seanjc@google.com> Date: Tue, 13 Jul 2021 09:33:09 -0700 In-Reply-To: <20210713163324.627647-1-seanjc@google.com> Message-Id: <20210713163324.627647-32-seanjc@google.com> Mime-Version: 1.0 References: <20210713163324.627647-1-seanjc@google.com> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog Subject: [PATCH v2 31/46] KVM: SVM: Drop redundant writes to vmcb->save.cr4 at RESET/INIT From: Sean Christopherson <seanjc@google.com> To: Paolo Bonzini <pbonzini@redhat.com> Cc: Sean Christopherson <seanjc@google.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, Wanpeng Li <wanpengli@tencent.com>, Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Reiji Watanabe <reijiw@google.com> Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: <kvm.vger.kernel.org> X-Mailing-List: kvm@vger.kernel.org |
Series |
KVM: x86: vCPU RESET/INIT fixes and consolidation
|
expand
|
diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 875d68c4cb9b..6eff7f1a4672 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -1269,8 +1269,6 @@ static void init_vmcb(struct kvm_vcpu *vcpu) kvm_set_rflags(vcpu, X86_EFLAGS_FIXED); vcpu->arch.regs[VCPU_REGS_RIP] = 0x0000fff0; - save->cr4 = X86_CR4_PAE; - if (npt_enabled) { /* Setup VMCB for Nested Paging */ control->nested_ctl |= SVM_NESTED_CTL_NP_ENABLE; @@ -1280,7 +1278,6 @@ static void init_vmcb(struct kvm_vcpu *vcpu) svm_clr_intercept(svm, INTERCEPT_CR3_WRITE); save->g_pat = vcpu->arch.pat; save->cr3 = 0; - save->cr4 = 0; } svm->current_vmcb->asid_generation = 0; svm->asid = 0;