diff mbox series

[vfio] vfio/virtio: Declare virtiovf_pci_aer_reset_done() static

Message ID 20231220082456.241973-1-yishaih@nvidia.com (mailing list archive)
State New, archived
Headers show
Series [vfio] vfio/virtio: Declare virtiovf_pci_aer_reset_done() static | expand

Commit Message

Yishai Hadas Dec. 20, 2023, 8:24 a.m. UTC
Declare virtiovf_pci_aer_reset_done() as a static function to prevent
the below build warning.

"warning: no previous prototype for 'virtiovf_pci_aer_reset_done'
[-Wmissing-prototypes]"

Fixes: eb61eca0e8c3 ("vfio/virtio: Introduce a vfio driver over virtio devices")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/lkml/20231220143122.63337669@canb.auug.org.au/
Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
---
 drivers/vfio/pci/virtio/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Williamson Dec. 20, 2023, 3:32 p.m. UTC | #1
On Wed, 20 Dec 2023 10:24:56 +0200
Yishai Hadas <yishaih@nvidia.com> wrote:

> Declare virtiovf_pci_aer_reset_done() as a static function to prevent
> the below build warning.
> 
> "warning: no previous prototype for 'virtiovf_pci_aer_reset_done'
> [-Wmissing-prototypes]"
> 
> Fixes: eb61eca0e8c3 ("vfio/virtio: Introduce a vfio driver over virtio devices")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/lkml/20231220143122.63337669@canb.auug.org.au/
> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
> ---
>  drivers/vfio/pci/virtio/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/virtio/main.c b/drivers/vfio/pci/virtio/main.c
> index 291c55b641f1..d5af683837d3 100644
> --- a/drivers/vfio/pci/virtio/main.c
> +++ b/drivers/vfio/pci/virtio/main.c
> @@ -547,7 +547,7 @@ static const struct pci_device_id virtiovf_pci_table[] = {
>  
>  MODULE_DEVICE_TABLE(pci, virtiovf_pci_table);
>  
> -void virtiovf_pci_aer_reset_done(struct pci_dev *pdev)
> +static void virtiovf_pci_aer_reset_done(struct pci_dev *pdev)
>  {
>  	struct virtiovf_pci_core_device *virtvdev = dev_get_drvdata(&pdev->dev);
>  

Applied to vfio next branch for v6.8.  Thanks,

Alex
diff mbox series

Patch

diff --git a/drivers/vfio/pci/virtio/main.c b/drivers/vfio/pci/virtio/main.c
index 291c55b641f1..d5af683837d3 100644
--- a/drivers/vfio/pci/virtio/main.c
+++ b/drivers/vfio/pci/virtio/main.c
@@ -547,7 +547,7 @@  static const struct pci_device_id virtiovf_pci_table[] = {
 
 MODULE_DEVICE_TABLE(pci, virtiovf_pci_table);
 
-void virtiovf_pci_aer_reset_done(struct pci_dev *pdev)
+static void virtiovf_pci_aer_reset_done(struct pci_dev *pdev)
 {
 	struct virtiovf_pci_core_device *virtvdev = dev_get_drvdata(&pdev->dev);