| Message ID | 20200712163341.61410-1-ajaykumar.rs@samsung.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add DT support for arm_smmuv3_pmu driver | expand |
On 2020-07-12 17:33, Ajay Kumar wrote: > Currently, only those platforms using ACPI can enable > arm_smmuv3_pmu driver. This patchset adds support for > enabling arm_smmuv3_pmu driver on platforms which do not > enable ACPI and instead rely on DT. This must be a popular topic all of a sudden, since it's barely a week since the last one! https://lore.kernel.org/linux-arm-kernel/20200706112246.92220-1-jkchen@linux.alibaba.com/ I'm not sure whether Jay has seen my review since Alibaba's mail server apparently decided to reject the direct reply as spam, but some of what I said there applies here too. Could we please try to coordinate where we go from here so we're not all wasting time developing and reviewing multiple versions of the exact same thing? Robin. > > Ajay Kumar (4): > perf/smmuv3: Remove dependency on CONFIG_ACPI > Documentation: perf: Add documentation for arm-smmu-v3-pmcg > perf/smmuv3: add device tree support > perf/smmuv3: fix crash when platdata not specified > > .../bindings/perf/arm-smmu-v3-pmcg.txt | 21 +++++++++++++++++++ > drivers/perf/Kconfig | 2 +- > drivers/perf/arm_smmuv3_pmu.c | 11 ++++++++-- > 3 files changed, 31 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/perf/arm-smmu-v3-pmcg.txt >
On 13/07/2020 10:42, Robin Murphy wrote: > On 2020-07-12 17:33, Ajay Kumar wrote: >> Currently, only those platforms using ACPI can enable >> arm_smmuv3_pmu driver. This patchset adds support for >> enabling arm_smmuv3_pmu driver on platforms which do not >> enable ACPI and instead rely on DT. > > This must be a popular topic all of a sudden, since it's barely a week > since the last one! > > https://lore.kernel.org/linux-arm-kernel/20200706112246.92220-1-jkchen@linux.alibaba.com/ > JFYI, I don't have that mail (so can't reply directly), but hisi platforms which have SMMUv3 PMCG don't support DT intentionally, and there is a desire to avoid headache of HW-specific DT support there in future. thanks > > I'm not sure whether Jay has seen my review since Alibaba's mail server > apparently decided to reject the direct reply as spam, but some of what > I said there applies here too. Could we please try to coordinate where > we go from here so we're not all wasting time developing and reviewing > multiple versions of the exact same thing? > > Robin. > >> >> Ajay Kumar (4): >> perf/smmuv3: Remove dependency on CONFIG_ACPI >> Documentation: perf: Add documentation for arm-smmu-v3-pmcg >> perf/smmuv3: add device tree support >> perf/smmuv3: fix crash when platdata not specified >> >> .../bindings/perf/arm-smmu-v3-pmcg.txt | 21 +++++++++++++++++++ >> drivers/perf/Kconfig | 2 +- >> drivers/perf/arm_smmuv3_pmu.c | 11 ++++++++-- >> 3 files changed, 31 insertions(+), 3 deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/perf/arm-smmu-v3-pmcg.txt >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > .
Hi Robin and Garry, On 7/13/20, John Garry <john.garry@huawei.com> wrote: > On 13/07/2020 10:42, Robin Murphy wrote: >> On 2020-07-12 17:33, Ajay Kumar wrote: >>> Currently, only those platforms using ACPI can enable >>> arm_smmuv3_pmu driver. This patchset adds support for >>> enabling arm_smmuv3_pmu driver on platforms which do not >>> enable ACPI and instead rely on DT. >> >> This must be a popular topic all of a sudden, since it's barely a week >> since the last one! >> >> https://lore.kernel.org/linux-arm-kernel/20200706112246.92220-1-jkchen@linux.alibaba.com/ >> >> > > JFYI, I don't have that mail (so can't reply directly), but hisi > platforms which have SMMUv3 PMCG don't support DT intentionally, and > there is a desire to avoid headache of HW-specific DT support there in > future. The patchset allows support for both DT and ACPI to co-exist. >> >> I'm not sure whether Jay has seen my review since Alibaba's mail server >> apparently decided to reject the direct reply as spam, but some of what >> I said there applies here too. Could we please try to coordinate where >> we go from here so we're not all wasting time developing and reviewing >> multiple versions of the exact same thing? Agreed. I checked Jay's patchset: https://lore.kernel.org/linux-arm-kernel/20200706112246.92220-1-jkchen@linux.alibaba.com/ Pretty much tries to achieve the same thing. Its Jay's call now. > > > >> >> Robin. >> >>> >>> Ajay Kumar (4): >>> perf/smmuv3: Remove dependency on CONFIG_ACPI >>> Documentation: perf: Add documentation for arm-smmu-v3-pmcg >>> perf/smmuv3: add device tree support >>> perf/smmuv3: fix crash when platdata not specified >>> >>> .../bindings/perf/arm-smmu-v3-pmcg.txt | 21 +++++++++++++++++++ >>> drivers/perf/Kconfig | 2 +- >>> drivers/perf/arm_smmuv3_pmu.c | 11 ++++++++-- >>> 3 files changed, 31 insertions(+), 3 deletions(-) >>> create mode 100644 >>> Documentation/devicetree/bindings/perf/arm-smmu-v3-pmcg.txt >>> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> . > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On 2020-07-13 10:57, John Garry wrote: > On 13/07/2020 10:42, Robin Murphy wrote: >> On 2020-07-12 17:33, Ajay Kumar wrote: >>> Currently, only those platforms using ACPI can enable >>> arm_smmuv3_pmu driver. This patchset adds support for >>> enabling arm_smmuv3_pmu driver on platforms which do not >>> enable ACPI and instead rely on DT. >> >> This must be a popular topic all of a sudden, since it's barely a week >> since the last one! >> >> https://lore.kernel.org/linux-arm-kernel/20200706112246.92220-1-jkchen@linux.alibaba.com/ >> > > JFYI, I don't have that mail (so can't reply directly), but hisi > platforms which have SMMUv3 PMCG don't support DT intentionally, and > there is a desire to avoid headache of HW-specific DT support there in > future. Thanks John, I was wondering about that, since I do have a vague memory of a promise that you guys would never ask for DT support yourselves :) Perhaps someone at Huawei can follow up directly with Alibaba about their use-case and whether there's a better way to support it upstream (if at all). Bonus tip: If you download a "raw" link from lore and save it with a .eml extension, Thunderbird can then be convinced to open it in a manner which can be replied to. Robin. > > thanks > >> >> I'm not sure whether Jay has seen my review since Alibaba's mail >> server apparently decided to reject the direct reply as spam, but some >> of what I said there applies here too. Could we please try to >> coordinate where we go from here so we're not all wasting time >> developing and reviewing multiple versions of the exact same thing? > > > >> >> Robin. >> >>> >>> Ajay Kumar (4): >>> perf/smmuv3: Remove dependency on CONFIG_ACPI >>> Documentation: perf: Add documentation for arm-smmu-v3-pmcg >>> perf/smmuv3: add device tree support >>> perf/smmuv3: fix crash when platdata not specified >>> >>> .../bindings/perf/arm-smmu-v3-pmcg.txt | 21 +++++++++++++++++++ >>> drivers/perf/Kconfig | 2 +- >>> drivers/perf/arm_smmuv3_pmu.c | 11 ++++++++-- >>> 3 files changed, 31 insertions(+), 3 deletions(-) >>> create mode 100644 >>> Documentation/devicetree/bindings/perf/arm-smmu-v3-pmcg.txt >>> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> . >