mbox series

[0/8] hwtracing: Convert to platform remove callback returning void

Message ID 20231107202818.4005791-1-u.kleine-koenig@pengutronix.de (mailing list archive)
Headers show
Series hwtracing: Convert to platform remove callback returning void | expand

Message

Uwe Kleine-König Nov. 7, 2023, 8:28 p.m. UTC
Hello,

after a fix for a resource leak this series converts all platform
drivers below drivers/hwtracing to .remove_new(). See commit
5c5a7680e67b ("platform: Provide a remove callback that returns no
value") for an extended explanation and the eventual goal.

Best regards
Uwe

Uwe Kleine-König (8):
  coresight: ultrasoc-smb: Fix resource leak in .remove()
  coresight: dummy: Convert to platform remove callback returning void
  coresight: etm4x: Convert to platform remove callback returning void
  coresight: funnel: Convert to platform remove callback returning void
  coresight: replicator: Convert to platform remove callback returning
    void
  coresight: trbe: Convert to platform remove callback returning void
  intel_th: Convert to platform remove callback returning void
  coresight: ultrasoc-smb: Convert to platform remove callback returning
    void

 drivers/hwtracing/coresight/coresight-dummy.c      |  5 ++---
 drivers/hwtracing/coresight/coresight-etm4x-core.c |  6 ++----
 drivers/hwtracing/coresight/coresight-funnel.c     |  5 ++---
 drivers/hwtracing/coresight/coresight-replicator.c |  5 ++---
 drivers/hwtracing/coresight/coresight-trbe.c       |  5 ++---
 drivers/hwtracing/coresight/ultrasoc-smb.c         | 11 +++--------
 drivers/hwtracing/intel_th/acpi.c                  |  6 ++----
 7 files changed, 15 insertions(+), 28 deletions(-)

base-commit: 5cd631a52568a18b12fd2563418985c8cb63e4b0

Comments

James Clark Nov. 9, 2023, 11:13 a.m. UTC | #1
On 07/11/2023 20:28, Uwe Kleine-König wrote:
> Hello,
> 
> after a fix for a resource leak this series converts all platform
> drivers below drivers/hwtracing to .remove_new(). See commit
> 5c5a7680e67b ("platform: Provide a remove callback that returns no
> value") for an extended explanation and the eventual goal.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (8):
>   coresight: ultrasoc-smb: Fix resource leak in .remove()
>   coresight: dummy: Convert to platform remove callback returning void
>   coresight: etm4x: Convert to platform remove callback returning void
>   coresight: funnel: Convert to platform remove callback returning void
>   coresight: replicator: Convert to platform remove callback returning
>     void
>   coresight: trbe: Convert to platform remove callback returning void
>   intel_th: Convert to platform remove callback returning void
>   coresight: ultrasoc-smb: Convert to platform remove callback returning
>     void
> 
>  drivers/hwtracing/coresight/coresight-dummy.c      |  5 ++---
>  drivers/hwtracing/coresight/coresight-etm4x-core.c |  6 ++----
>  drivers/hwtracing/coresight/coresight-funnel.c     |  5 ++---
>  drivers/hwtracing/coresight/coresight-replicator.c |  5 ++---
>  drivers/hwtracing/coresight/coresight-trbe.c       |  5 ++---
>  drivers/hwtracing/coresight/ultrasoc-smb.c         | 11 +++--------
>  drivers/hwtracing/intel_th/acpi.c                  |  6 ++----
>  7 files changed, 15 insertions(+), 28 deletions(-)
> 
> base-commit: 5cd631a52568a18b12fd2563418985c8cb63e4b0

For the whole set:

Reviewed-by: James Clark <james.clark@arm.com>

Although I'm not sure what the resolution should be on patch 1 with
Junhao's other change.