| Message ID | 1f0c4fa62d6849753e2138cce5498693cfc3a230.1715332922.git.andrea.porta@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add minimal boot support for Raspberry Pi 5 | expand |
Hi Andrea, please drop E. Anholt from the recipients. AFAIK she is not interested in kernel development anymore. Am 10.05.24 um 16:35 schrieb Andrea della Porta: > The BCM2712 has an SDHCI capable host interface similar to the one found > in other STB chipsets. Add the relevant compatible string and relative > example. > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > --- > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > index cbd3d6c6c77f..404b75fa7adb 100644 > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > @@ -13,6 +13,10 @@ maintainers: > properties: > compatible: > oneOf: > + - items: > + - enum: > + - brcm,bcm2712-sdhci > + - const: brcm,sdhci-brcmstb > - items: > - enum: > - brcm,bcm7216-sdhci > @@ -114,3 +118,22 @@ examples: > clocks = <&scmi_clk 245>; > clock-names = "sw_sdio"; > }; > + > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + soc { > + #address-cells = <2>; > + #size-cells = <2>; Would be nice to have a short explanation in the commit message why this is necessary. > + > + mmc@1000fff000 { > + compatible = "brcm,bcm2712-sdhci", > + "brcm,sdhci-brcmstb"; > + reg = <0x10 0x00fff000 0x0 0x260>, > + <0x10 0x00fff400 0x0 0x200>; > + reg-names = "host", "cfg"; > + mmc-ddr-3_3v; > + interrupts = <GIC_SPI 0x111 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk_emmc2>; > + clock-names = "sw_sdio"; > + }; > + };
On Fri, May 10, 2024 at 09:01:33PM +0200, Stefan Wahren wrote: > Hi Andrea, > > please drop E. Anholt from the recipients. AFAIK she is not interested > in kernel development anymore. > > Am 10.05.24 um 16:35 schrieb Andrea della Porta: > > The BCM2712 has an SDHCI capable host interface similar to the one found > > in other STB chipsets. Add the relevant compatible string and relative > > example. > > > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > > --- > > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 23 +++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > index cbd3d6c6c77f..404b75fa7adb 100644 > > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > @@ -13,6 +13,10 @@ maintainers: > > properties: > > compatible: > > oneOf: > > + - items: > > + - enum: > > + - brcm,bcm2712-sdhci > > + - const: brcm,sdhci-brcmstb > > - items: > > - enum: > > - brcm,bcm7216-sdhci > > @@ -114,3 +118,22 @@ examples: > > clocks = <&scmi_clk 245>; > > clock-names = "sw_sdio"; > > }; > > + > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > Would be nice to have a short explanation in the commit message why this > is necessary. That has nothing to do with *this* patch. It's needed because 'reg' is dependent on it and the examples default to 1 cell. In any case, please just drop the example. A new compatible doesn't justify another example. Rob
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml index cbd3d6c6c77f..404b75fa7adb 100644 --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml @@ -13,6 +13,10 @@ maintainers: properties: compatible: oneOf: + - items: + - enum: + - brcm,bcm2712-sdhci + - const: brcm,sdhci-brcmstb - items: - enum: - brcm,bcm7216-sdhci @@ -114,3 +118,22 @@ examples: clocks = <&scmi_clk 245>; clock-names = "sw_sdio"; }; + + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + soc { + #address-cells = <2>; + #size-cells = <2>; + + mmc@1000fff000 { + compatible = "brcm,bcm2712-sdhci", + "brcm,sdhci-brcmstb"; + reg = <0x10 0x00fff000 0x0 0x260>, + <0x10 0x00fff400 0x0 0x200>; + reg-names = "host", "cfg"; + mmc-ddr-3_3v; + interrupts = <GIC_SPI 0x111 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk_emmc2>; + clock-names = "sw_sdio"; + }; + };
The BCM2712 has an SDHCI capable host interface similar to the one found in other STB chipsets. Add the relevant compatible string and relative example. Signed-off-by: Andrea della Porta <andrea.porta@suse.com> --- .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+)