| Message ID | 20190304222841.13899-5-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce the generic ECC engine abstraction | expand |
On Mon, 4 Mar 2019 23:28:09 +0100 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Before introducing the generic ECC engine abstraction, we need to be > sure that raw NAND and SPI-NAND speak the same language: let's use the > generic NAND layer with the raw NAND part (the SPI-NAND one already > uses it). Nit: I'm not sure it's useful to compile/depends on the generic NAND layer until you actually start using it. I would have selected MTD_NAND_CORE in the patch that starts using some of the functions exposed there, but that's just a tiny detail. Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/mtd/nand/raw/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > index ebb8a3da9fa5..952dc50a8634 100644 > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -11,6 +11,7 @@ config MTD_NAND_ECC_SW_HAMMING_SMC > > menuconfig MTD_RAW_NAND > tristate "Raw/Parallel NAND Device Support" > + select MTD_NAND_CORE > select MTD_NAND_ECC_SW_HAMMING > help > This enables support for accessing all type of raw/parallel
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index ebb8a3da9fa5..952dc50a8634 100644 --- a/drivers/mtd/nand/raw/Kconfig +++ b/drivers/mtd/nand/raw/Kconfig @@ -11,6 +11,7 @@ config MTD_NAND_ECC_SW_HAMMING_SMC menuconfig MTD_RAW_NAND tristate "Raw/Parallel NAND Device Support" + select MTD_NAND_CORE select MTD_NAND_ECC_SW_HAMMING help This enables support for accessing all type of raw/parallel
Before introducing the generic ECC engine abstraction, we need to be sure that raw NAND and SPI-NAND speak the same language: let's use the generic NAND layer with the raw NAND part (the SPI-NAND one already uses it). Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/raw/Kconfig | 1 + 1 file changed, 1 insertion(+)