| Message ID | 20200419170810.5738-7-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Modularizing Versatile Express | expand |
On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote: > > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > timers, they are not needed since the arch timers are used instead. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Arnd Bergmann <arnd@arndb.de> > > config CLK_SP810 > bool "Clock driver for ARM SP810 System Controller" > - default y if ARCH_VEXPRESS > + default y if (ARCH_VEXPRESS && ARM) But maybe add "|| (COMPILE_TEST && OF)" for extra points. Arnd
On Mon, Apr 20, 2020 at 10:26 AM Arnd Bergmann <arnd@arndb.de> wrote: > > On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote: > > > > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > > timers, they are not needed since the arch timers are used instead. > > > > Cc: Catalin Marinas <catalin.marinas@arm.com> > > Cc: Will Deacon <will@kernel.org> > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Stephen Boyd <sboyd@kernel.org> > > Cc: linux-clk@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > > > config CLK_SP810 > > bool "Clock driver for ARM SP810 System Controller" > > - default y if ARCH_VEXPRESS > > + default y if (ARCH_VEXPRESS && ARM) > > But maybe add "|| (COMPILE_TEST && OF)" for extra points. On a 'default y'? Not necessary. Rob
On Mon, Apr 20, 2020 at 7:48 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Apr 20, 2020 at 10:26 AM Arnd Bergmann <arnd@arndb.de> wrote: > > > > On Sun, Apr 19, 2020 at 7:08 PM Rob Herring <robh@kernel.org> wrote: > > > > > > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > > > timers, they are not needed since the arch timers are used instead. > > > > > > Cc: Catalin Marinas <catalin.marinas@arm.com> > > > Cc: Will Deacon <will@kernel.org> > > > Cc: Liviu Dudau <liviu.dudau@arm.com> > > > Cc: Sudeep Holla <sudeep.holla@arm.com> > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Stephen Boyd <sboyd@kernel.org> > > > Cc: linux-clk@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > > > > > > config CLK_SP810 > > > bool "Clock driver for ARM SP810 System Controller" > > > - default y if ARCH_VEXPRESS > > > + default y if (ARCH_VEXPRESS && ARM) > > > > But maybe add "|| (COMPILE_TEST && OF)" for extra points. > > On a 'default y'? Not necessary. Ah right, that would indeed result in negative points. Arnd
Quoting Rob Herring (2020-04-19 10:07:59) > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > timers, they are not needed since the arch timers are used instead. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- Acked-by: Stephen Boyd <sboyd@kernel.org>
On Sun, Apr 19, 2020 at 12:07:59PM -0500, Rob Herring wrote: > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > timers, they are not needed since the arch timers are used instead. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Liviu Dudau <liviu.dudau@arm.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/clk/versatile/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > index 3465fb291998..5bdd5c98990b 100644 > --- a/drivers/clk/versatile/Kconfig > +++ b/drivers/clk/versatile/Kconfig > @@ -9,7 +9,7 @@ config ICST > > config CLK_SP810 > bool "Clock driver for ARM SP810 System Controller" > - default y if ARCH_VEXPRESS > + default y if (ARCH_VEXPRESS && ARM) > ---help--- > Supports clock muxing (REFCLK/TIMCLK to TIMERCLKEN0-3) capabilities > of the ARM SP810 System Controller cell. > -- > 2.20.1 >
On Sun, Apr 19, 2020 at 12:07:59PM -0500, Rob Herring wrote: > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > timers, they are not needed since the arch timers are used instead. > Shouldn't we disable selection of SP804 for arm64 at the same time ?
On Wed, Apr 22, 2020 at 3:52 PM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Sun, Apr 19, 2020 at 12:07:59PM -0500, Rob Herring wrote: > > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > > timers, they are not needed since the arch timers are used instead. > > > > Shouldn't we disable selection of SP804 for arm64 at the same time ? SP804 is already not selected for VEXPRESS. Only RPi and HiSilicon enable it on arm64. Though it makes me wonder why they require it as they should have arch timer too. Rob
diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig index 3465fb291998..5bdd5c98990b 100644 --- a/drivers/clk/versatile/Kconfig +++ b/drivers/clk/versatile/Kconfig @@ -9,7 +9,7 @@ config ICST config CLK_SP810 bool "Clock driver for ARM SP810 System Controller" - default y if ARCH_VEXPRESS + default y if (ARCH_VEXPRESS && ARM) ---help--- Supports clock muxing (REFCLK/TIMCLK to TIMERCLKEN0-3) capabilities of the ARM SP810 System Controller cell.
While 64-bit Arm reference platforms have SP810 for clocks for SP804 timers, they are not needed since the arch timers are used instead. Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Stephen Boyd <sboyd@kernel.org> Cc: linux-clk@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/clk/versatile/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)