| Message ID | 20200629124752.1018358-2-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 9443f2c88ad916cad7efcd40fabc3e8c33c98594 |
| Headers | show |
| Series | Fix a bunch of W=1 warnings in PWM | expand |
On 6/29/2020 5:47 AM, Lee Jones wrote: > 'duty' here is an unsigned int, thus checking for <0 will always > evaluate to false. > > Fixes the following W=1 warning: > > drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-pwm@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> And IPROC_PWM_DUTY_CYCLE_MIN is unused after remove this single use of the define, if you also remove it you can add: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On 2020-06-29 9:45 a.m., Florian Fainelli wrote: > > On 6/29/2020 5:47 AM, Lee Jones wrote: >> 'duty' here is an unsigned int, thus checking for <0 will always >> evaluate to false. >> >> Fixes the following W=1 warning: >> >> drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] >> >> Cc: Ray Jui <rjui@broadcom.com> >> Cc: Scott Branden <sbranden@broadcom.com> >> Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> >> Cc: bcm-kernel-feedback-list@broadcom.com >> Cc: linux-pwm@vger.kernel.org >> Signed-off-by: Lee Jones <lee.jones@linaro.org> > And IPROC_PWM_DUTY_CYCLE_MIN is unused after remove this single use of > the define, if you also remove it you can add: > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> We actually made this same change internally recently but hadn't upstreamed it yet. Tested-by: Scott Branden <scott.branden@broadcom.com>
On Mon, Jun 29, 2020 at 01:47:49PM +0100, Lee Jones wrote: > 'duty' here is an unsigned int, thus checking for <0 will always > evaluate to false. > > Fixes the following W=1 warning: > > drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-pwm@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/pwm/pwm-bcm-iproc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c > index 1f829edd8ee70..46f0a45e9049c 100644 > --- a/drivers/pwm/pwm-bcm-iproc.c > +++ b/drivers/pwm/pwm-bcm-iproc.c > @@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm, > value = rate * state->duty_cycle; > duty = div64_u64(value, div); > > - if (period < IPROC_PWM_PERIOD_MIN || > - duty < IPROC_PWM_DUTY_CYCLE_MIN) > + if (period < IPROC_PWM_PERIOD_MIN) > return -EINVAL; > > if (period <= IPROC_PWM_PERIOD_MAX && Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c index 1f829edd8ee70..46f0a45e9049c 100644 --- a/drivers/pwm/pwm-bcm-iproc.c +++ b/drivers/pwm/pwm-bcm-iproc.c @@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm, value = rate * state->duty_cycle; duty = div64_u64(value, div); - if (period < IPROC_PWM_PERIOD_MIN || - duty < IPROC_PWM_DUTY_CYCLE_MIN) + if (period < IPROC_PWM_PERIOD_MIN) return -EINVAL; if (period <= IPROC_PWM_PERIOD_MAX &&
'duty' here is an unsigned int, thus checking for <0 will always evaluate to false. Fixes the following W=1 warning: drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-pwm@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/pwm/pwm-bcm-iproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)