| Message ID | 20200629124752.1018358-3-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 75de72591aa8ffa3acdc14cc1d3708ce8ac09245 |
| Headers | show |
| Series | Fix a bunch of W=1 warnings in PWM | expand |
On 6/29/2020 5:47 AM, Lee Jones wrote: > 'dc' here is an unsigned long, thus checking for <0 will always > evaluate to false. > > Fixes the following W=1 warning: > > drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-pwm@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you remove it as well, you can add: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On Mon, Jun 29, 2020 at 09:45:31AM -0700, Florian Fainelli wrote: > > > On 6/29/2020 5:47 AM, Lee Jones wrote: > > 'dc' here is an unsigned long, thus checking for <0 will always > > evaluate to false. > > > > Fixes the following W=1 warning: > > > > drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > > > Cc: Florian Fainelli <f.fainelli@gmail.com> > > Cc: Ray Jui <rjui@broadcom.com> > > Cc: Scott Branden <sbranden@broadcom.com> > > Cc: bcm-kernel-feedback-list@broadcom.com > > Cc: linux-pwm@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you > remove it as well, you can add: > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Even without removing DUTY_CYCLE_HIGH_MIN (which might still serve as documentation): Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 81da91df2529a..16c5898b934a8 100644 --- a/drivers/pwm/pwm-bcm-kona.c +++ b/drivers/pwm/pwm-bcm-kona.c @@ -138,7 +138,7 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm, dc = div64_u64(val, div); /* If duty_ns or period_ns are not achievable then return */ - if (pc < PERIOD_COUNT_MIN || dc < DUTY_CYCLE_HIGH_MIN) + if (pc < PERIOD_COUNT_MIN) return -EINVAL; /* If pc and dc are in bounds, the calculation is done */
'dc' here is an unsigned long, thus checking for <0 will always evaluate to false. Fixes the following W=1 warning: drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-pwm@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/pwm/pwm-bcm-kona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)