| Message ID | 20201008143722.21888-3-etienne.carriere@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] firmware: arm_scmi: always initialize protocols | expand |
On Thu, Oct 08, 2020 at 04:37:20PM +0200, Etienne Carriere wrote: > Fix dependencies for configuration switch ARM_SCMI_PROTOCOL that > is not exclusively dependent on MAILBOX since the alternate > smc transport that is depends on HAVE_ARM_SMCCC_DISCOVERY since [1]. > Do you need any build issues ? I don't see why this is needed.
On Thu, 8 Oct 2020 at 23:08, Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Thu, Oct 08, 2020 at 04:37:20PM +0200, Etienne Carriere wrote: > > Fix dependencies for configuration switch ARM_SCMI_PROTOCOL that > > is not exclusively dependent on MAILBOX since the alternate > > smc transport that is depends on HAVE_ARM_SMCCC_DISCOVERY since [1]. > > > > Do you need any build issues ? I don't see why this is needed. > This change is for consistency of the kernel configuration. Without this change, a kernel configured without CONFIG_MAILBOX cannot embed SCMI support even is using only the SMC transport enabled thanks to HAVE_ARM_SMCCC_DISCOVERY. Regards, Etienne > -- > Regards, > Sudeep
On Fri, Oct 09, 2020 at 02:33:41PM +0200, Etienne Carriere wrote: > On Thu, 8 Oct 2020 at 23:08, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > On Thu, Oct 08, 2020 at 04:37:20PM +0200, Etienne Carriere wrote: > > > Fix dependencies for configuration switch ARM_SCMI_PROTOCOL that > > > is not exclusively dependent on MAILBOX since the alternate > > > smc transport that is depends on HAVE_ARM_SMCCC_DISCOVERY since [1]. > > > > > > > Do you need any build issues ? I don't see why this is needed. > > > > This change is for consistency of the kernel configuration. > Without this change, a kernel configured without CONFIG_MAILBOX > cannot embed SCMI support even is using only the SMC transport > enabled thanks to HAVE_ARM_SMCCC_DISCOVERY. > Fair enough, however instead of adding to the list for each added transport we need to do better transport abstraction now that we have multiple. I don't see this as critical, let me know if you disagree.
On Fri, 9 Oct 2020 at 17:58, Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Fri, Oct 09, 2020 at 02:33:41PM +0200, Etienne Carriere wrote: > > On Thu, 8 Oct 2020 at 23:08, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > > > On Thu, Oct 08, 2020 at 04:37:20PM +0200, Etienne Carriere wrote: > > > > Fix dependencies for configuration switch ARM_SCMI_PROTOCOL that > > > > is not exclusively dependent on MAILBOX since the alternate > > > > smc transport that is depends on HAVE_ARM_SMCCC_DISCOVERY since [1]. > > > > > > > > > > Do you need any build issues ? I don't see why this is needed. > > > > > > > This change is for consistency of the kernel configuration. > > Without this change, a kernel configured without CONFIG_MAILBOX > > cannot embed SCMI support even is using only the SMC transport > > enabled thanks to HAVE_ARM_SMCCC_DISCOVERY. > > > > Fair enough, however instead of adding to the list for each added transport > we need to do better transport abstraction now that we have multiple. > I don't see this as critical, let me know if you disagree. Not critical, I agree :) etienne > > -- > Regards, > Sudeep
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 3315e3c21586..5bdd411206ff 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -9,7 +9,7 @@ menu "Firmware Drivers" config ARM_SCMI_PROTOCOL tristate "ARM System Control and Management Interface (SCMI) Message Protocol" depends on ARM || ARM64 || COMPILE_TEST - depends on MAILBOX + depends on MAILBOX || HAVE_ARM_SMCCC_DISCOVERY help ARM System Control and Management Interface (SCMI) protocol is a set of operating system-independent software interfaces that are
Fix dependencies for configuration switch ARM_SCMI_PROTOCOL that is not exclusively dependent on MAILBOX since the alternate smc transport that is depends on HAVE_ARM_SMCCC_DISCOVERY since [1]. Link: [1] d76428237784 ("firmware: arm_scmi: Use HAVE_ARM_SMCCC_DISCOVERY instead of ARM_PSCI_FW") Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> --- drivers/firmware/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)