diff mbox series

[5/5] firmware: arm_scmi: fix ARCH_COLD_RESET

Message ID 20201008143722.21888-5-etienne.carriere@linaro.org (mailing list archive)
State New, archived
Headers show
Series [1/5] firmware: arm_scmi: always initialize protocols | expand

Commit Message

Etienne Carriere Oct. 8, 2020, 2:37 p.m. UTC 
Fix ARCH_COLD_RESET according to SCMI specification.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
 drivers/firmware/arm_scmi/reset.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Sudeep Holla Oct. 8, 2020, 9:16 p.m. UTC | #1 
On Thu, Oct 08, 2020 at 04:37:22PM +0200, Etienne Carriere wrote:
> Fix ARCH_COLD_RESET according to SCMI specification.
>

Thanks, nice catch.
I will send this as fix after v5.10-rc1 with fixes tag

Fixes: 95a15d80aa0d ("firmware: arm_scmi: Add RESET protocol in SCMI v2.0")
diff mbox series

Patch

diff --git a/drivers/firmware/arm_scmi/reset.c b/drivers/firmware/arm_scmi/reset.c
index f063cfe17e02..a981a22cfe89 100644
--- a/drivers/firmware/arm_scmi/reset.c
+++ b/drivers/firmware/arm_scmi/reset.c
@@ -36,9 +36,7 @@  struct scmi_msg_reset_domain_reset {
 #define EXPLICIT_RESET_ASSERT	BIT(1)
 #define ASYNCHRONOUS_RESET	BIT(2)
 	__le32 reset_state;
-#define ARCH_RESET_TYPE		BIT(31)
-#define COLD_RESET_STATE	BIT(0)
-#define ARCH_COLD_RESET		(ARCH_RESET_TYPE | COLD_RESET_STATE)
+#define ARCH_COLD_RESET		0
 };
 
 struct scmi_msg_reset_notify {