[05/10] clk: imx: scu: bypass pi_pll enable status restore

Commit Message

Aisheng Dong June 4, 2021, 9:09 a.m. UTC

PI PLL does not support enable/disable. So bypass it's
enable status restore.

Signed-off-by: Dong Aisheng <[e-mail]>
---
 drivers/clk/imx/clk-scu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Abel Vesa June 14, 2021, 8:57 a.m. UTC | #1

On 21-06-04 17:09:38, Dong Aisheng wrote:
> PI PLL does not support enable/disable. So bypass it's
> enable status restore.
> 
> Signed-off-by: Dong Aisheng <[e-mail]>

Looks OK to me.

Reviewed-by: Abel Vesa <[e-mail]>

> ---
>  drivers/clk/imx/clk-scu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index 95fcac7f73b6..2537e68ded16 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -573,7 +573,7 @@ static int __maybe_unused imx_clk_scu_resume(struct device *dev)
>  			!ret ? "success" : "failed");
>  	}
>  
> -	if (clk->is_enabled) {
> +	if (clk->is_enabled && rsrc_id != IMX_SC_R_PI_0_PLL) {
>  		ret = clk_scu_prepare(&clk->hw);
>  		dev_dbg(dev, "restore enabled state %s\n",
>  			!ret ? "success" : "failed");
> -- 
> 2.25.1
>

Patch

diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
index 95fcac7f73b6..2537e68ded16 100644
--- a/drivers/clk/imx/clk-scu.c
+++ b/drivers/clk/imx/clk-scu.c
@@ -573,7 +573,7 @@  static int __maybe_unused imx_clk_scu_resume(struct device *dev)
 			!ret ? "success" : "failed");
 	}
 
-	if (clk->is_enabled) {
+	if (clk->is_enabled && rsrc_id != IMX_SC_R_PI_0_PLL) {
 		ret = clk_scu_prepare(&clk->hw);
 		dev_dbg(dev, "restore enabled state %s\n",
 			!ret ? "success" : "failed");