| Message ID | 20210927154159.2168500-1-robert.marko@sartura.hr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] arm64: dts: marvell: espressobin-ultra: enable UART output by default | expand |
On Mon, Sep 27, 2021 at 05:41:56PM +0200, Robert Marko wrote: > Since Espressobin Ultra board has a microUSB port > with the onboard USB to UART connected to it to be > used as a debug UART it makes no sense to require > the bootloader to pass console args to the kernel in > order to get console working. > > So, use the "stdout-path" property to enable the UART > output on the microUSB port by default. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Monday 27 September 2021 17:41:56 Robert Marko wrote: > Since Espressobin Ultra board has a microUSB port > with the onboard USB to UART connected to it to be > used as a debug UART it makes no sense to require > the bootloader to pass console args to the kernel in > order to get console working. > > So, use the "stdout-path" property to enable the UART > output on the microUSB port by default. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > --- > arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > index c5eb3604dd5b..c1770ceff3c1 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > @@ -15,6 +15,10 @@ / { > compatible = "globalscale,espressobin-ultra", "marvell,armada3720", > "marvell,armada3710"; > > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + This code is duplication of common espressobin code from armada-3720-espressobin.dtsi file: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > aliases { > /* ethernet1 is WAN port */ > ethernet1 = &switch0port5; > -- > 2.31.1 >
On Tue, Sep 28, 2021 at 5:13 PM Pali Rohár <pali@kernel.org> wrote: > > On Monday 27 September 2021 17:41:56 Robert Marko wrote: > > Since Espressobin Ultra board has a microUSB port > > with the onboard USB to UART connected to it to be > > used as a debug UART it makes no sense to require > > the bootloader to pass console args to the kernel in > > order to get console working. > > > > So, use the "stdout-path" property to enable the UART > > output on the microUSB port by default. > > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > --- > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > index c5eb3604dd5b..c1770ceff3c1 100644 > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > @@ -15,6 +15,10 @@ / { > > compatible = "globalscale,espressobin-ultra", "marvell,armada3720", > > "marvell,armada3710"; > > > > + chosen { > > + stdout-path = "serial0:115200n8"; > > + }; > > + > > This code is duplication of common espressobin code from > armada-3720-espressobin.dtsi file: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi Ahh yes, I don't know why was it not working by default then. Sorry for the noise, I will drop this patch. Regards, Robert > > > aliases { > > /* ethernet1 is WAN port */ > > ethernet1 = &switch0port5; > > -- > > 2.31.1 > >
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts index c5eb3604dd5b..c1770ceff3c1 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts @@ -15,6 +15,10 @@ / { compatible = "globalscale,espressobin-ultra", "marvell,armada3720", "marvell,armada3710"; + chosen { + stdout-path = "serial0:115200n8"; + }; + aliases { /* ethernet1 is WAN port */ ethernet1 = &switch0port5;
Since Espressobin Ultra board has a microUSB port with the onboard USB to UART connected to it to be used as a debug UART it makes no sense to require the bootloader to pass console args to the kernel in order to get console working. So, use the "stdout-path" property to enable the UART output on the microUSB port by default. Signed-off-by: Robert Marko <robert.marko@sartura.hr> --- arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 4 ++++ 1 file changed, 4 insertions(+)